sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

device/pci_ops: Change ramstage PCI accessor signatures

Browse Source 
This reduces parameter passing and visibility of
parsing struct *dev to PCI bus:dev.fn.

Change-Id: Ie4232ca1db9cffdf21ed133143acfb7517577736
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/31750
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
This commit is contained in:
Kyösti Mälkki
2019-03-04 08:25:27 +02:00
committed by Nico Huber
parent 6fefdfd106
commit ad7758ca52
4 changed files with 44 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/device/pci_ops.c
View File

@@ -36,41 +36,35 @@ static void pcidev_assert(const struct device *dev)
u8 pci_read_config8(struct device *dev, unsigned int where)
{
pcidev_assert(dev);
return pci_bus_ops()->read8(dev->bus->secondary,
dev->path.pci.devfn, where);
return pci_bus_ops()->read8(dev, where);
}
u16 pci_read_config16(struct device *dev, unsigned int where)
{
pcidev_assert(dev);
return pci_bus_ops()->read16(dev->bus->secondary,
dev->path.pci.devfn, where);
return pci_bus_ops()->read16(dev, where);
}
u32 pci_read_config32(struct device *dev, unsigned int where)
{
pcidev_assert(dev);
return pci_bus_ops()->read32(dev->bus->secondary,
dev->path.pci.devfn, where);
return pci_bus_ops()->read32(dev, where);
}
void pci_write_config8(struct device *dev, unsigned int where, u8 val)
{
pcidev_assert(dev);
pci_bus_ops()->write8(dev->bus->secondary,
dev->path.pci.devfn, where, val);
pci_bus_ops()->write8(dev, where, val);
}
void pci_write_config16(struct device *dev, unsigned int where, u16 val)
{
pcidev_assert(dev);
pci_bus_ops()->write16(dev->bus->secondary,
dev->path.pci.devfn, where, val);
pci_bus_ops()->write16(dev, where, val);
}
void pci_write_config32(struct device *dev, unsigned int where, u32 val)
{
pcidev_assert(dev);
pci_bus_ops()->write32(dev->bus->secondary,
dev->path.pci.devfn, where, val);
pci_bus_ops()->write32(dev, where, val);
}