sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

sb/intel: Remove spurious HAVE_SMI_HANDLER test

Browse Source 
There are no side-effects in calling acpi_is_wakeup_s3()
and apm_control() is a no-op with HAVE_SMI_HANDLER=n.

Change-Id: Ia9195781955cc5fa96d0690aa7735fc590e527e4
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/41986
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Kyösti Mälkki
2020-06-02 05:05:30 +03:00
committed by Patrick Georgi
parent b6585481e8
commit ad882c3b17
9 changed files with 25 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/southbridge/intel/i82801gx/lpc.c
View File

@@ -314,12 +314,10 @@ static void enable_clock_gating(void)
static void i82801gx_set_acpi_mode(struct device *dev)
{
if (CONFIG(HAVE_SMI_HANDLER)) {
if (!acpi_is_wakeup_s3()) {
apm_control(APM_CNT_ACPI_DISABLE);
} else {
apm_control(APM_CNT_ACPI_ENABLE);
}
if (!acpi_is_wakeup_s3()) {
apm_control(APM_CNT_ACPI_DISABLE);
} else {
apm_control(APM_CNT_ACPI_ENABLE);
}
}