sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Eliminate do_div().

Browse Source 
This eliminates the use of do_div() in favor of using libgcc
functions.

This was tested by building and booting on Google Snow (ARMv7)
and Qemu (x86). printk()s which use division in vtxprintf() look good.

Change-Id: Icad001d84a3c05bfbf77098f3d644816280b4a4d
Signed-off-by: Gabe Black <gabeblack@chromium.org>
Signed-off-by: David Hendricks <dhendrix@chromium.org>
Reviewed-on: http://review.coreboot.org/2606
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Ronald G. Minnich <rminnich@gmail.com>
This commit is contained in:
David Hendricks
2013-03-06 20:43:55 -08:00
committed by Ronald G. Minnich
parent 31c5e07a04
commit ae0e8d3613
9 changed files with 11 additions and 495 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/console/vtxprintf.c
View File

@ -5,7 +5,6 @@
*/
#include <string.h>
#include <div64.h>
#include <console/console.h>
#include <console/vtxprintf.h>
@ -70,20 +69,8 @@ static int number(void (*tx_byte)(unsigned char byte),
if (num == 0)
tmp[i++]='0';
else while (num != 0){
/* there are some nice optimizations in the
* Macros-From-Hell that form the div64 code
* *IF* you call it with a constant.
* We're firmware, we only do bases
* 8, 10, and 16. Let's be smart.
* This greatly helps ARM, reduces the
* code footprint at compile time, and does not hurt x86.
*/
if (base == 10)
tmp[i++] = digits[do_div(num,10)];
else if (base == 8)
tmp[i++] = digits[do_div(num,8)];
else /* sorry, you're out of choices */
tmp[i++] = digits[do_div(num,16)];
tmp[i++] = digits[num % base];
num /= base;
}
if (i > precision)
precision = i;