sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/broadwell: Drop enable check from LPD0/LPD3

Browse Source 
When SerialIO devices are disabled, their _STA method evaluates to 0,
which means the device is not present. It is expected that OSPM would
not attempt to change the power state of a device that is not present.
Lynxpoint does not have these checks, thus remove them from Broadwell.
Also remove the now-unused Arg1 parameter to avoid warnings from IASL.

Change-Id: Ic5e999ac1171ce49db66bec45c58d8aa5711ec53
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/46966
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Michael Niewöhner <foss@mniewoehner.de>
This commit is contained in:
Angel Pons
2020-10-29 15:34:48 +01:00
parent 0ec903a73b
commit ae4eba9be5
1 changed files with 14 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
src/soc/intel/broadwell/pch/acpi/serialio.asl
View File

@@ -7,14 +7,8 @@
// Put SerialIO device in D0 state
// Arg0 - BAR1 of device
// Arg1 - Set if device is in ACPI mode
Method (LPD0, 2, Serialized)
Method (LPD0, 1, Serialized)
{
// PCI mode devices will be handled by OS PCI bus driver
If (Arg1 == 0) {
Return
}
OperationRegion (SPRT, SystemMemory, Arg0 + 0x84, 4)
Field (SPRT, DWordAcc, NoLock, Preserve)
{
@@ -30,14 +24,8 @@ Method (LPD0, 2, Serialized)
// Put SerialIO device in D3 state
// Arg0 - BAR1 of device
// Arg1 - Set if device is in ACPI mode
Method (LPD3, 2, Serialized)
Method (LPD3, 1, Serialized)
{
// PCI mode devices will be handled by OS PCI bus driver
If (Arg1 == 0) {
Return
}
OperationRegion (SPRT, SystemMemory, Arg0 + 0x84, 4)
Field (SPRT, DWordAcc, NoLock, Preserve)
{
@@ -240,12 +228,12 @@ Device (I2C0)
Method (_PS0, 0, Serialized)
{
^^LPD0 (\S1B1, \S1EN)
^^LPD0 (\S1B1)
}
Method (_PS3, 0, Serialized)
{
^^LPD3 (\S1B1, \S1EN)
^^LPD3 (\S1B1)
}
}
@@ -311,12 +299,12 @@ Device (I2C1)
Method (_PS0, 0, Serialized)
{
^^LPD0 (\S2B1, \S2EN)
^^LPD0 (\S2B1)
}
Method (_PS3, 0, Serialized)
{
^^LPD3 (\S2B1, \S2EN)
^^LPD3 (\S2B1)
}
}
@@ -367,12 +355,12 @@ Device (SPI0)
Method (_PS0, 0, Serialized)
{
^^LPD0 (\S3B1, \S3EN)
^^LPD0 (\S3B1)
}
Method (_PS3, 0, Serialized)
{
^^LPD3 (\S3B1, \S3EN)
^^LPD3 (\S3B1)
}
}
@@ -435,12 +423,12 @@ Device (SPI1)
Method (_PS0, 0, Serialized)
{
^^LPD0 (\S4B1, \S4EN)
^^LPD0 (\S4B1)
}
Method (_PS3, 0, Serialized)
{
^^LPD3 (\S4B1, \S4EN)
^^LPD3 (\S4B1)
}
}
@@ -503,12 +491,12 @@ Device (UAR0)
Method (_PS0, 0, Serialized)
{
^^LPD0 (\S5B1, \S5EN)
^^LPD0 (\S5B1)
}
Method (_PS3, 0, Serialized)
{
^^LPD3 (\S5B1, \S5EN)
^^LPD3 (\S5B1)
}
}
@@ -559,12 +547,12 @@ Device (UAR1)
Method (_PS0, 0, Serialized)
{
^^LPD0 (\S6B1, \S6EN)
^^LPD0 (\S6B1)
}
Method (_PS3, 0, Serialized)
{
^^LPD3 (\S6B1, \S6EN)
^^LPD3 (\S6B1)
}
}