mb/google/{brya,brox,rex}: Update ec_sync wake capability
Some of the boards use the EC_SYNC pin to wake the AP but do not
advertise the pin as wake capable in the CREC _CRS resource.  Relevant
boards were determined through empirical testing and inspection of gpio
configuration.
Update the ACPI tables for rex, brya, and brox based boards to advertise
their EC_SYNC pin as wake capable.
BUG=b:243700486
TEST=-Dump ACPI and verify ExclusiveAndWake share type is set when
     EC_SYNC_IRQ_WAKE_CAPABLE is defined
     -Wake Aviko via keypress and verify chromeos-ec as wake source
     -Wake Screebo via lid open and verify chromeos-ec as wake source
Change-Id: I5828be7c9420cab6ae838272c8301c302a3e078c
Signed-off-by: Mark Hasemeyer <markhas@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/79374
Reviewed-by: Eric Lai <ericllai@google.com>
Reviewed-by: Nick Vaccaro <nvaccaro@google.com>
Reviewed-by: Kapil Porwal <kapilporwal@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Subrata Banik <subratabanik@google.com>
			
			
This commit is contained in:
		
				
					committed by
					
						 Subrata Banik
						Subrata Banik
					
				
			
			
				
	
			
			
			
						parent
						
							677d15e8a8
						
					
				
				
					commit
					aef345bfd7
				
			| @@ -75,5 +75,6 @@ | |||||||
| #define SIO_EC_ENABLE_PS2K       /* Enable PS/2 Keyboard */ | #define SIO_EC_ENABLE_PS2K       /* Enable PS/2 Keyboard */ | ||||||
|  |  | ||||||
| #define EC_ENABLE_SYNC_IRQ      /* Enable tight timestamp / wake support */ | #define EC_ENABLE_SYNC_IRQ      /* Enable tight timestamp / wake support */ | ||||||
|  | #define EC_SYNC_IRQ_WAKE_CAPABLE /* Let the OS know ec_sync is wake capable */ | ||||||
|  |  | ||||||
| #endif /* __BASEBOARD_EC_H__ */ | #endif /* __BASEBOARD_EC_H__ */ | ||||||
|   | |||||||
| @@ -41,5 +41,6 @@ | |||||||
| #define SIO_EC_HOST_ENABLE       /* EC Host Interface Resources */ | #define SIO_EC_HOST_ENABLE       /* EC Host Interface Resources */ | ||||||
|  |  | ||||||
| #define EC_ENABLE_SYNC_IRQ      /* Enable tight timestamp / wake support */ | #define EC_ENABLE_SYNC_IRQ      /* Enable tight timestamp / wake support */ | ||||||
|  | #define EC_SYNC_IRQ_WAKE_CAPABLE /* Let the OS know ec_sync is wake capable */ | ||||||
|  |  | ||||||
| #endif /* __BASEBOARD_EC_H__ */ | #endif /* __BASEBOARD_EC_H__ */ | ||||||
|   | |||||||
| @@ -80,5 +80,6 @@ | |||||||
| #define SIO_EC_ENABLE_PS2K       /* Enable PS/2 Keyboard */ | #define SIO_EC_ENABLE_PS2K       /* Enable PS/2 Keyboard */ | ||||||
|  |  | ||||||
| #define EC_ENABLE_SYNC_IRQ      /* Enable tight timestamp / wake support */ | #define EC_ENABLE_SYNC_IRQ      /* Enable tight timestamp / wake support */ | ||||||
|  | #define EC_SYNC_IRQ_WAKE_CAPABLE /* Let the OS know ec_sync is wake capable */ | ||||||
|  |  | ||||||
| #endif /* __BASEBOARD_EC_H__ */ | #endif /* __BASEBOARD_EC_H__ */ | ||||||
|   | |||||||
| @@ -70,5 +70,6 @@ | |||||||
| #define SIO_EC_ENABLE_PS2K       /* Enable PS/2 Keyboard */ | #define SIO_EC_ENABLE_PS2K       /* Enable PS/2 Keyboard */ | ||||||
|  |  | ||||||
| #define EC_ENABLE_SYNC_IRQ      /* Enable tight timestamp / wake support */ | #define EC_ENABLE_SYNC_IRQ      /* Enable tight timestamp / wake support */ | ||||||
|  | #define EC_SYNC_IRQ_WAKE_CAPABLE /* Let the OS know ec_sync is wake capable */ | ||||||
|  |  | ||||||
| #endif /* __BASEBOARD_EC_H__ */ | #endif /* __BASEBOARD_EC_H__ */ | ||||||
|   | |||||||
| @@ -60,5 +60,6 @@ | |||||||
| #define SIO_EC_ENABLE_PS2K       /* Enable PS/2 Keyboard */ | #define SIO_EC_ENABLE_PS2K       /* Enable PS/2 Keyboard */ | ||||||
|  |  | ||||||
| #define EC_ENABLE_SYNC_IRQ      /* Enable tight timestamp / wake support */ | #define EC_ENABLE_SYNC_IRQ      /* Enable tight timestamp / wake support */ | ||||||
|  | #define EC_SYNC_IRQ_WAKE_CAPABLE /* Let the OS know ec_sync is wake capable */ | ||||||
|  |  | ||||||
| #endif /* __BASEBOARD_EC_H__ */ | #endif /* __BASEBOARD_EC_H__ */ | ||||||
|   | |||||||
| @@ -74,5 +74,6 @@ | |||||||
| #define SIO_EC_ENABLE_PS2K       /* Enable PS/2 Keyboard */ | #define SIO_EC_ENABLE_PS2K       /* Enable PS/2 Keyboard */ | ||||||
|  |  | ||||||
| #define EC_ENABLE_SYNC_IRQ      /* Enable tight timestamp / wake support */ | #define EC_ENABLE_SYNC_IRQ      /* Enable tight timestamp / wake support */ | ||||||
|  | #define EC_SYNC_IRQ_WAKE_CAPABLE /* Let the OS know ec_sync is wake capable */ | ||||||
|  |  | ||||||
| #endif /* __BASEBOARD_EC_H__ */ | #endif /* __BASEBOARD_EC_H__ */ | ||||||
|   | |||||||
		Reference in New Issue
	
	Block a user