From b01b47654677ddb7d14023f2e233b3151a287aa3 Mon Sep 17 00:00:00 2001 From: Ravi Kumar Bokka Date: Fri, 6 Nov 2020 11:28:01 +0530 Subject: [PATCH] soc/qualcomm: move uart_bitbang UART w/gpio code to common BUG=b:182963902 TEST=Validated on qualcomm sc7280 development board Change-Id: Ic6c70f917a59e233f6ea518d9c39f73fe84991c3 Signed-off-by: Ravi Kumar Bokka Reviewed-on: https://review.coreboot.org/c/coreboot/+/47284 Reviewed-by: Shelley Chen Tested-by: build bot (Jenkins) --- src/soc/qualcomm/{sc7180 => common}/uart_bitbang.c | 3 +-- src/soc/qualcomm/sc7180/Makefile.inc | 2 +- src/soc/qualcomm/sc7180/include/soc/uart.h | 8 ++++++++ src/soc/qualcomm/sc7280/Makefile.inc | 1 + src/soc/qualcomm/sc7280/include/soc/uart.h | 8 ++++++++ 5 files changed, 19 insertions(+), 3 deletions(-) rename src/soc/qualcomm/{sc7180 => common}/uart_bitbang.c (95%) create mode 100644 src/soc/qualcomm/sc7180/include/soc/uart.h create mode 100644 src/soc/qualcomm/sc7280/include/soc/uart.h diff --git a/src/soc/qualcomm/sc7180/uart_bitbang.c b/src/soc/qualcomm/common/uart_bitbang.c similarity index 95% rename from src/soc/qualcomm/sc7180/uart_bitbang.c rename to src/soc/qualcomm/common/uart_bitbang.c index 7d88a20986..943dcf8a06 100644 --- a/src/soc/qualcomm/sc7180/uart_bitbang.c +++ b/src/soc/qualcomm/common/uart_bitbang.c @@ -3,8 +3,7 @@ #include #include #include - -#define UART_TX_PIN GPIO(44) +#include void uart_fill_lb(void *data) { diff --git a/src/soc/qualcomm/sc7180/Makefile.inc b/src/soc/qualcomm/sc7180/Makefile.inc index e84dcc8d0e..5ac1f3fe6c 100644 --- a/src/soc/qualcomm/sc7180/Makefile.inc +++ b/src/soc/qualcomm/sc7180/Makefile.inc @@ -17,7 +17,7 @@ all-y += qupv3_config.c ################################################################################ bootblock-y += bootblock.c bootblock-y += mmu.c -bootblock-$(CONFIG_DRIVERS_UART) += uart_bitbang.c +bootblock-$(CONFIG_DRIVERS_UART) += ../common/uart_bitbang.c ################################################################################ verstage-$(CONFIG_DRIVERS_UART) += qupv3_uart.c diff --git a/src/soc/qualcomm/sc7180/include/soc/uart.h b/src/soc/qualcomm/sc7180/include/soc/uart.h new file mode 100644 index 0000000000..e6b2e62a24 --- /dev/null +++ b/src/soc/qualcomm/sc7180/include/soc/uart.h @@ -0,0 +1,8 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#ifndef _SOC_QUALCOMM_SC7180_UART_TX_H_ +#define _SOC_QUALCOMM_SC7180_UART_TX_H_ + +#define UART_TX_PIN GPIO(44) + +#endif /* _SOC_QUALCOMM_SC7180_UART_TX_H_ */ diff --git a/src/soc/qualcomm/sc7280/Makefile.inc b/src/soc/qualcomm/sc7280/Makefile.inc index abcc3fb175..3c34be010c 100644 --- a/src/soc/qualcomm/sc7280/Makefile.inc +++ b/src/soc/qualcomm/sc7280/Makefile.inc @@ -7,6 +7,7 @@ all-y += ../common/gpio.c ################################################################################ bootblock-y += bootblock.c bootblock-y += mmu.c +bootblock-$(CONFIG_DRIVERS_UART) += ../common/uart_bitbang.c ################################################################################ romstage-y += cbmem.c diff --git a/src/soc/qualcomm/sc7280/include/soc/uart.h b/src/soc/qualcomm/sc7280/include/soc/uart.h new file mode 100644 index 0000000000..2b2f2809d4 --- /dev/null +++ b/src/soc/qualcomm/sc7280/include/soc/uart.h @@ -0,0 +1,8 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#ifndef _SOC_QUALCOMM_SC7280_UART_TX_H_ +#define _SOC_QUALCOMM_SC7280_UART_TX_H_ + +#define UART_TX_PIN GPIO(22) + +#endif /* _SOC_QUALCOMM_SC7280_UART_TX_H_ */