sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

drivers/intel/fsp2_0: Update the debug levels

Browse Source 
Choose appropriate debug levels for the various messages in the FSP
driver.  Change:

* BIOS_DEBUG --> BIOS_SPEW: Normal FSP driver output level, allows
  builder to disable FSP driver output by selecting
  CONFIG_DEFAULT_CONSOLE_LOGLEVEL_7

* BIOS_ERROR --> BIOS_CRIT: These errors will prevent coreboot and the
  payload from successfully booting

TEST=Build and run on Galileo Gen2

Change-Id: Ic3352de2022e16482bf47fc953aedeef8f0c2880
Signed-off-by: Lee Leahy <leroy.p.leahy@intel.com>
Reviewed-on: https://review.coreboot.org/16003
Tested-by: build bot (Jenkins)
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
This commit is contained in:
Lee Leahy
2016-07-31 16:49:28 -07:00
parent 94e502be7a
commit b20d4ba57a
3 changed files with 15 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/drivers/intel/fsp2_0/util.c
View File

@ -68,13 +68,13 @@ enum cb_err fsp_validate_component(struct fsp_header *hdr,
membase = rdev_mmap(rdev, FSP_HDR_OFFSET, FSP_HDR_LEN);
if (membase == NULL) {
printk(BIOS_ERR, "Could not mmap() FSP header.\n");
printk(BIOS_CRIT, "Could not mmap() FSP header.\n");
return CB_ERR;
}
if (fsp_identify(hdr, membase) != CB_SUCCESS) {
rdev_munmap(rdev, membase);
printk(BIOS_ERR, "No valid FSP header\n");
printk(BIOS_CRIT, "No valid FSP header\n");
return CB_ERR;
}
@ -85,7 +85,7 @@ enum cb_err fsp_validate_component(struct fsp_header *hdr,
/* Check if size specified in the header matches the cbfs file size */
if (region_device_sz(rdev) < hdr->image_size) {
printk(BIOS_ERR, "Component size bigger than cbfs file.\n");
printk(BIOS_CRIT, "Component size bigger than cbfs file.\n");
return CB_ERR;
}
@ -103,7 +103,7 @@ void fsp_handle_reset(enum fsp_status status)
if (!fsp_reset_requested(status))
return;
printk(BIOS_DEBUG, "FSP: handling reset type %x\n", status);
printk(BIOS_SPEW, "FSP: handling reset type %x\n", status);
switch(status) {
case FSP_STATUS_RESET_REQUIRED_COLD: