sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/*/*/smihandler: Remove bogus SMM init

Browse Source 
I does nothing on these boards. It's just a call a local noop function
which only prints a debug-level message.

Change-Id: Id3fb2e9074db72d9025b95f7d4918417dd488b9e
Signed-off-by: Peter Lemenkov <lemenkov@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/36236
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Patrick Rudolph <siro@das-labor.org>
This commit is contained in:
Peter Lemenkov
2019-10-22 18:36:59 +02:00
committed by Patrick Georgi
parent 8c09b82cb1
commit b2832e3586
3 changed files with 0 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/mainboard/apple/macbook21/smihandler.c
View File

@@ -21,20 +21,8 @@
#define GPE_EC_SCI 12 #define GPE_EC_SCI 12
static void mainboard_smm_init(void)
{
printk(BIOS_DEBUG, "initializing SMI\n");
}
int mainboard_io_trap_handler(int smif) int mainboard_io_trap_handler(int smif)
{ {
static int smm_initialized;
if (!smm_initialized) {
mainboard_smm_init();
smm_initialized = 1;
}
switch (smif) { switch (smif) {
default: default:
return 0; return 0;

12
src/mainboard/lenovo/s230u/smihandler.c
View File

@@ -32,20 +32,8 @@
/* FIXME: check this */ /* FIXME: check this */
#define GPE_EC_WAKE 13 #define GPE_EC_WAKE 13
static void mainboard_smm_init(void)
{
printk(BIOS_DEBUG, "initializing SMI\n");
}
int mainboard_io_trap_handler(int smif) int mainboard_io_trap_handler(int smif)
{ {
static int smm_initialized;
if (!smm_initialized) {
mainboard_smm_init();
smm_initialized = 1;
}
return 0; return 0;
} }

12
src/mainboard/packardbell/ms2290/smihandler.c
View File

@@ -22,20 +22,8 @@
#include <northbridge/intel/nehalem/nehalem.h> #include <northbridge/intel/nehalem/nehalem.h>
#include <ec/acpi/ec.h> #include <ec/acpi/ec.h>
static void mainboard_smm_init(void)
{
printk(BIOS_DEBUG, "initializing SMI\n");
}
int mainboard_io_trap_handler(int smif) int mainboard_io_trap_handler(int smif)
{ {
static int smm_initialized;
if (!smm_initialized) {
mainboard_smm_init();
smm_initialized = 1;
}
switch (smif) { switch (smif) {
default: default: