soc/intel/common: Use coreboot error codes

The patch uses coreboot error codes instead of uint8_t data type in the
pre_mem_debug_init function.

TEST=build code for Gimble

Signed-off-by: Sridhar Siricilla <sridhar.siricilla@intel.com>
Change-Id: I957ff764900cb789bf2aacf0472dcb281f48af07
Reviewed-on: https://review.coreboot.org/c/coreboot/+/64301
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Maulik V Vaghela <maulik.v.vaghela@intel.com>
This commit is contained in:
Sridhar Siricilla
2022-04-28 14:36:38 +05:30
committed by Martin L Roth
parent ab5b7b3ead
commit b4de261228
2 changed files with 4 additions and 4 deletions

View File

@@ -27,12 +27,12 @@ bool is_debug_cse_fw_update_disable(void)
return pre_mem_debug.cse_fw_update_disable == 1; return pre_mem_debug.cse_fw_update_disable == 1;
} }
uint8_t pre_mem_debug_init(void) enum cb_err pre_mem_debug_init(void)
{ {
if (spi_flash_read(boot_device_spi_flash(), PRE_MEM_FEATURE_CTRL_OFFSET, if (spi_flash_read(boot_device_spi_flash(), PRE_MEM_FEATURE_CTRL_OFFSET,
PRE_MEM_FEATURE_CTRL_SZ, &pre_mem_debug)) { PRE_MEM_FEATURE_CTRL_SZ, &pre_mem_debug)) {
printk(BIOS_ERR, "Failed to read Descriptor Region from SPI Flash\n"); printk(BIOS_ERR, "Failed to read Descriptor Region from SPI Flash\n");
return 1; return CB_ERR;
} }
return 0; return CB_SUCCESS;
} }

View File

@@ -12,6 +12,6 @@ bool is_debug_cse_fw_update_disable(void);
* Reads OEM Section area in the Descriptor Region and * Reads OEM Section area in the Descriptor Region and
* populates pre_mem_debug structure. * populates pre_mem_debug structure.
*/ */
uint8_t pre_mem_debug_init(void); enum cb_err pre_mem_debug_init(void);
#endif #endif