sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

util/cbfstool: fix memory leak in compress.c

Browse Source 
free the memory allocated in lz4_compress
function before returning from it.

Reported-by: Coverity (CID:1469433)

Signed-off-by: Solomon Alan-Dei <alandei.solomon@gmail.com>
Change-Id: I8698090d519964348e51fc3b6f2023d06d81fcd5
Reviewed-on: https://review.coreboot.org/c/coreboot/+/69021
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Julius Werner <jwerner@chromium.org>
This commit is contained in:
Solomon Alan-Dei 2022-10-30 03:49:59 -06:00 committed by Felix Held
parent bb4b793f4a
commit b4e94c8b01
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
util/cbfstool/compress.c
View File

@ -23,9 +23,12 @@ static int lz4_compress(char *in, int in_len, char *out, int *out_len)
if (!bounce)
return -1;
*out_len = LZ4F_compressFrame(bounce, worst_size, in, in_len, &prefs);
if (LZ4F_isError(*out_len) || *out_len >= in_len)
if (LZ4F_isError(*out_len) || *out_len >= in_len) {
free(bounce);
return -1;
}
memcpy(out, bounce, *out_len);
free(bounce);
return 0;
}