sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/amd/picasso/pci_gpp: Replace the swizzle string with a u8 array

Browse Source 
I think it makes the code a bit cleaner.

BUG=b:170595019
BRANCH=zork
TEST=boot zork with pci=nomsi and verify /proc/interrupts didn't change

Signed-off-by: Raul E Rangel <rrangel@chromium.org>
Change-Id: Ib5e8e5b690d9612e8ae257f5d15c25122e1c91e6
Reviewed-on: https://review.coreboot.org/c/coreboot/+/49842
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com>
This commit is contained in:
Raul E Rangel
2021-01-22 09:53:18 -07:00
committed by Felix Held
parent 91839eef5c
commit b5e27a81cc
1 changed files with 11 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
src/soc/amd/picasso/pcie_gpp.c
View File

@@ -21,20 +21,20 @@
struct pci_routing {
unsigned int devfn;
unsigned int group;
const char intx[5];
uint8_t pin[4];
};
/* See AMD PPR 55570 - IOAPIC Initialization for the table that AGESA sets up */
static const struct pci_routing pci_routing_table[] = {
{PCIE_GPP_0_DEVFN, 0, "ABCD"},
{PCIE_GPP_1_DEVFN, 1, "ABCD"},
{PCIE_GPP_2_DEVFN, 2, "ABCD"},
{PCIE_GPP_3_DEVFN, 3, "ABCD"},
{PCIE_GPP_4_DEVFN, 4, "ABCD"},
{PCIE_GPP_5_DEVFN, 5, "ABCD"},
{PCIE_GPP_6_DEVFN, 6, "ABCD"},
{PCIE_GPP_A_DEVFN, 7, "ABCD"},
{PCIE_GPP_B_DEVFN, 7, "CDAB"},
{PCIE_GPP_0_DEVFN, 0, {PIRQ_A, PIRQ_B, PIRQ_C, PIRQ_D} },
{PCIE_GPP_1_DEVFN, 1, {PIRQ_A, PIRQ_B, PIRQ_C, PIRQ_D} },
{PCIE_GPP_2_DEVFN, 2, {PIRQ_A, PIRQ_B, PIRQ_C, PIRQ_D} },
{PCIE_GPP_3_DEVFN, 3, {PIRQ_A, PIRQ_B, PIRQ_C, PIRQ_D} },
{PCIE_GPP_4_DEVFN, 4, {PIRQ_A, PIRQ_B, PIRQ_C, PIRQ_D} },
{PCIE_GPP_5_DEVFN, 5, {PIRQ_A, PIRQ_B, PIRQ_C, PIRQ_D} },
{PCIE_GPP_6_DEVFN, 6, {PIRQ_A, PIRQ_B, PIRQ_C, PIRQ_D} },
{PCIE_GPP_A_DEVFN, 7, {PIRQ_A, PIRQ_B, PIRQ_C, PIRQ_D} },
{PCIE_GPP_B_DEVFN, 7, {PIRQ_C, PIRQ_D, PIRQ_A, PIRQ_B} },
};
/*
@@ -71,7 +71,7 @@ static unsigned int calculate_irq(const struct pci_routing *pci_routing, unsigne
{
unsigned int irq_index;
irq_index = pci_routing->group * 4;
irq_index += pci_routing->intx[i] - 'A';
irq_index += pci_routing->pin[i];
return irq_index;
}