sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/amd/common: Only call into enabled memory types

Browse Source 
Don't call into disabled memory type code, it won't work.

Signed-off-by: Martin Roth <gaumless@gmail.com>
Change-Id: Ie239039b3dd2b5d0a6f8e9230fd3466bb8309761
Reviewed-on: https://review.coreboot.org/c/coreboot/+/68993
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Sean Rhodes <sean@starlabs.systems>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
This commit is contained in:
Martin Roth
2022-10-29 16:00:57 -06:00
committed by Felix Held
parent f2503fce3f
commit b6877e401a
1 changed files with 8 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/soc/amd/common/fsp/dmi.c
View File

@@ -23,19 +23,18 @@
*/ */
static uint16_t ddr_speed_mhz_to_reported_mts(uint16_t ddr_type, uint16_t speed) static uint16_t ddr_speed_mhz_to_reported_mts(uint16_t ddr_type, uint16_t speed)
{ {
switch (ddr_type) {
case MEMORY_TYPE_DDR4: if (CONFIG(USE_DDR4) && ddr_type == MEMORY_TYPE_DDR4)
return ddr4_speed_mhz_to_reported_mts(speed); return ddr4_speed_mhz_to_reported_mts(speed);
case MEMORY_TYPE_LPDDR4: else if (CONFIG(USE_LPDDR4) && ddr_type == MEMORY_TYPE_LPDDR4)
return lpddr4_speed_mhz_to_reported_mts(speed); return lpddr4_speed_mhz_to_reported_mts(speed);
case MEMORY_TYPE_DDR5: else if (CONFIG(USE_DDR5) && (ddr_type == MEMORY_TYPE_DDR5 ||
case MEMORY_TYPE_LPDDR5: ddr_type == MEMORY_TYPE_LPDDR5))
return ddr5_speed_mhz_to_reported_mts(speed); return ddr5_speed_mhz_to_reported_mts(speed);
default:
printk(BIOS_ERR, "Unknown memory type %x\n", ddr_type); printk(BIOS_ERR, "Unknown memory type %x\n", ddr_type);
return 0; return 0;
} }
}
/** /**
* Return DDR voltage (in mV) based on memory type * Return DDR voltage (in mV) based on memory type