sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cbmem.h: Drop cbmem_possible_online in favor of ENV_HAS_CBMEM

Browse Source 
The macro ENV_HAS_CBMEM achieves the same as this inline function.

Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Change-Id: I6d65ca51c863abe2106f794398ddd7d7d9ac4b5e
Reviewed-on: https://review.coreboot.org/c/coreboot/+/77166
Reviewed-by: Yu-Ping Wu <yupingso@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Jakub Czapiga <czapiga@google.com>
This commit is contained in:
Arthur Heymans
2023-08-11 11:31:05 +02:00
committed by Felix Held
parent bfadc78bd7
commit b7cbb7c431
9 changed files with 9 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/include/cbmem.h
View File

@@ -136,28 +136,12 @@ void cbmem_add_records_to_cbtable(struct lb_header *header);
#define CBMEM_READY_HOOK_EARLY(x) _CBMEM_INIT_HOOK_UNUSED(x)
#endif
/*
* Returns 0 for the stages where we know that cbmem does not come online.
* Even if this function returns 1 for romstage, depending upon the point in
* bootup, cbmem might not actually be online.
*/
static inline int cbmem_possibly_online(void)
{
if (ENV_BOOTBLOCK)
return 0;
if (ENV_SEPARATE_VERSTAGE && !CONFIG(VBOOT_STARTS_IN_ROMSTAGE))
return 0;
return 1;
}
/* Returns 1 after running cbmem init hooks, 0 otherwise. */
static inline int cbmem_online(void)
{
extern int cbmem_initialized;
if (!cbmem_possibly_online())
if (!ENV_HAS_CBMEM)
return 0;
return cbmem_initialized;