From b985cc0440ec30b66d2fb9eba34c9b42d830b3a3 Mon Sep 17 00:00:00 2001 From: Felix Held Date: Fri, 22 Mar 2024 16:30:08 +0100 Subject: [PATCH] soc/amd/common/cpu/noncar/memmap: use VGA MMIO defines everywhere Only the VGA MMIO range used the VGA_MMIO_* defines, but instead of using constants for the end of the region before that and the beginning of the region after that, the VGA_MMIO_* defines can be used. Signed-off-by: Felix Held Change-Id: I45c3888efb942cdd15416b730e36a9fb1ddd9697 Reviewed-on: https://review.coreboot.org/c/coreboot/+/81391 Tested-by: build bot (Jenkins) Reviewed-by: Matt DeVillier Reviewed-by: Marshall Dawson --- src/soc/amd/common/block/cpu/noncar/memmap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/soc/amd/common/block/cpu/noncar/memmap.c b/src/soc/amd/common/block/cpu/noncar/memmap.c index 488c209414..e6db85a2cc 100644 --- a/src/soc/amd/common/block/cpu/noncar/memmap.c +++ b/src/soc/amd/common/block/cpu/noncar/memmap.c @@ -42,13 +42,13 @@ void read_lower_soc_memmap_resources(struct device *dev, unsigned long *idx) const uintptr_t early_reserved_dram_end = e->base + e->size; /* 0x0 - 0x9ffff */ - ram_range(dev, (*idx)++, 0, 0xa0000); + ram_range(dev, (*idx)++, 0, VGA_MMIO_BASE); /* 0xa0000 - 0xbffff: legacy VGA */ mmio_range(dev, (*idx)++, VGA_MMIO_BASE, VGA_MMIO_SIZE); /* 0xc0000 - 0xfffff: Option ROM */ - reserved_ram_from_to(dev, (*idx)++, 0xc0000, 1 * MiB); + reserved_ram_from_to(dev, (*idx)++, VGA_MMIO_BASE + VGA_MMIO_SIZE, 1 * MiB); /* 1MiB - bottom of DRAM reserved for early coreboot usage */ ram_from_to(dev, (*idx)++, 1 * MiB, early_reserved_dram_start);