From b9a52a4c8d5e6a3ba912304ff2570f209efb330d Mon Sep 17 00:00:00 2001 From: Yu-Ping Wu Date: Tue, 16 Jul 2024 11:05:59 +0800 Subject: [PATCH] drivers/pc80/rtc/mc146818rtc: Use macros for CMOS addresses Replace integer literals with macros for CMOS addresses for readability. Change-Id: I454662c90fabb41af864728febdefa57f5ff2cb2 Signed-off-by: Yu-Ping Wu Reviewed-on: https://review.coreboot.org/c/coreboot/+/83477 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel Reviewed-by: Karthik Ramasubramanian --- src/drivers/pc80/rtc/mc146818rtc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/drivers/pc80/rtc/mc146818rtc.c b/src/drivers/pc80/rtc/mc146818rtc.c index 6474ecbd1a..b4ddadd4f7 100644 --- a/src/drivers/pc80/rtc/mc146818rtc.c +++ b/src/drivers/pc80/rtc/mc146818rtc.c @@ -97,9 +97,9 @@ static bool __cmos_init(bool invalid) if (invalid || cmos_invalid || checksum_invalid) { if (!CONFIG(USE_OPTION_TABLE)) { - cmos_write(0, 0x01); - cmos_write(0, 0x03); - cmos_write(0, 0x05); + cmos_write(0, RTC_CLK_SECOND_ALARM); + cmos_write(0, RTC_CLK_MINUTE_ALARM); + cmos_write(0, RTC_CLK_HOUR_ALARM); for (i = 10; i < 128; i++) cmos_write(0, i); cleared_cmos = true;