From b9dd0371f155a340584d5625b80a699a17cb5538 Mon Sep 17 00:00:00 2001 From: Reka Norman Date: Mon, 5 Jun 2023 09:54:45 +1000 Subject: [PATCH] mb/google/nissa/var/joxer: Remove VBOOT_GSC_BOARD_ID config Board IDs are now filled in as part of the signing process, so we don't need to set them in coreboot. BUG=b:240620735 TEST=Build and check VBOOT_GSC_BOARD_ID is set to ZZCR. Change-Id: I7dda8ad59046a1dd9a28595e037eda86e91c98df Signed-off-by: Reka Norman Reviewed-on: https://review.coreboot.org/c/coreboot/+/75641 Reviewed-by: Himanshu Sahdev Reviewed-by: Julius Werner Reviewed-by: Eric Lai Tested-by: build bot (Jenkins) --- src/mainboard/google/brya/Kconfig | 4 ---- src/security/vboot/Kconfig | 2 ++ 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/mainboard/google/brya/Kconfig b/src/mainboard/google/brya/Kconfig index ce10aa7258..893ec6a31c 100644 --- a/src/mainboard/google/brya/Kconfig +++ b/src/mainboard/google/brya/Kconfig @@ -292,10 +292,6 @@ config VBOOT select VBOOT_EARLY_EC_SYNC if !BOARD_GOOGLE_BASEBOARD_NISSA select VBOOT_LID_SWITCH -config VBOOT_GSC_BOARD_ID - string - default "LBTV" if BOARD_GOOGLE_JOXER - config DIMM_SPD_SIZE default 512 diff --git a/src/security/vboot/Kconfig b/src/security/vboot/Kconfig index a9981874cc..a2af5d2564 100644 --- a/src/security/vboot/Kconfig +++ b/src/security/vboot/Kconfig @@ -336,6 +336,8 @@ config VBOOT_GSC_BOARD_ID help GSC board ID to be embedded in the GSCVD. Usually each specific mainboard variant has its own. Google engineers can find these in the go/cros-dlm database ("Products"). + The specific board IDs are filled in as part of the production signing process, so + this value is just a default and doesn't need to be set per-variant in coreboot. (Note: This is a completely separate thing from coreboot's `board_id()` function.) menu "GBB configuration"