sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cpu/intel/car/p4-netburst: Remove delay loops

Browse Source 
While commented as 10 ms + 250 us, those delay loops actually
accounted for a total of 840 ms. And they seem unnecessary
as followup code has potentially infinite retries when
polling for status changes.

Tested on aopen/dxplplusu, dual-socket P4 Xeon HT model_f2x.

Change-Id: Ib7d1d66ed29c62d97073872f0b7809d719ac2324
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/36595
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
This commit is contained in:
Kyösti Mälkki
2019-11-03 10:29:49 +02:00
committed by Patrick Georgi
parent a751eec799
commit bc78e014c5
1 changed files with 0 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/cpu/intel/car/p4-netburst/cache_as_ram.S
View File

@@ -177,12 +177,6 @@ cores_counted:
hyper_threading_cpu: hyper_threading_cpu:
/* delay 10 ms */
movl $10000, %ecx
1: inb $0x80, %al
dec %ecx
jnz 1b
post_code(0x25) post_code(0x25)
/* Send Start IPI to all excluding ourself. */ /* Send Start IPI to all excluding ourself. */
@@ -198,12 +192,6 @@ hyper_threading_cpu:
andl $LAPIC_ICR_BUSY, %ecx andl $LAPIC_ICR_BUSY, %ecx
jnz 1b jnz 1b
/* delay 250 us */
movl $250, %ecx
1: inb $0x80, %al
dec %ecx
jnz 1b
post_code(0x26) post_code(0x26)
/* Wait for sibling CPU to start. */ /* Wait for sibling CPU to start. */