sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/amd/*: Move emmc disabling to device ops

Browse Source 
This allows for reduced use of chip_operations in the followup patch and
allows the allocator to skip over the used mmio.

Change-Id: I4052438185e7861792733b96a1298201c73fc3ff
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/68113
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Martin Roth <martin.roth@amd.corp-partner.google.com>
Reviewed-by: Fred Reitberger <reitbergerfred@gmail.com>
This commit is contained in:
Arthur Heymans
2022-10-04 14:53:56 +02:00
committed by Felix Held
parent d6b6b22616
commit bd15ece78a
9 changed files with 82 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/soc/amd/cezanne/chip.c
View File

@@ -1,12 +1,10 @@
/* SPDX-License-Identifier: GPL-2.0-only */
#include <amdblocks/aoac.h>
#include <console/console.h>
#include <device/device.h>
#include <device/pci.h>
#include <fsp/api.h>
#include <soc/acpi.h>
#include <soc/aoac_defs.h>
#include <soc/cpu.h>
#include <soc/data_fabric.h>
#include <soc/pci_devs.h>
@@ -18,6 +16,8 @@
extern struct device_operations soc_amd_i2c_mmio_ops;
/* Supplied by uart.c */
extern struct device_operations cezanne_uart_mmio_ops;
/* Supplied by emmc.c */
extern struct device_operations cezanne_emmc_mmio_ops;
struct device_operations cpu_bus_ops = {
.read_resources = noop_read_resources,
@@ -60,8 +60,7 @@ static void set_mmio_dev_ops(struct device *dev)
dev->ops = &cezanne_uart_mmio_ops;
break;
case APU_EMMC_BASE:
if (!dev->enabled)
power_off_aoac_device(FCH_AOAC_DEV_EMMC);
dev->ops = &cezanne_emmc_mmio_ops;
break;
}
}