sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/purism: Select NO_POST instead of overriding its dependencies

Browse Source 
Declaring a Kconfig symbol ahead to override its default also always
sets implicit dependencies. If the original symbol doesn't have any,
Kconfig gets confused.

Change-Id: Ie6d9ca96e4b6037eefd432dd386cb5e540deb0ed
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/30925
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
This commit is contained in:
Nico Huber
2019-01-14 23:45:46 +01:00
committed by Patrick Georgi
parent a6be58fece
commit bd294425c8
2 changed files with 2 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/mainboard/purism/librem_bdw/Kconfig
View File

@@ -7,6 +7,7 @@ config BOARD_PURISM_BASEBOARD_LIBREM_BDW
select HAVE_ACPI_TABLES select HAVE_ACPI_TABLES
select INTEL_INT15 select INTEL_INT15
select SOC_INTEL_BROADWELL select SOC_INTEL_BROADWELL
select NO_POST # This platform does not have any way to see POST codes
if BOARD_PURISM_BASEBOARD_LIBREM_BDW if BOARD_PURISM_BASEBOARD_LIBREM_BDW
@@ -63,12 +64,6 @@ config MAX_CPUS
int int
default 8 default 8
config NO_POST
def_bool y
help
This platform does not have any way to see POST codes
so disable them by default.
config PRE_GRAPHICS_DELAY config PRE_GRAPHICS_DELAY
int int
default 50 default 50

7
src/mainboard/purism/librem_skl/Kconfig
View File

@@ -11,6 +11,7 @@ config BOARD_PURISM_BASEBOARD_LIBREM_SKL
select MAINBOARD_USES_FSP2_0 select MAINBOARD_USES_FSP2_0
select SPD_READ_BY_WORD select SPD_READ_BY_WORD
select MAINBOARD_HAS_LPC_TPM select MAINBOARD_HAS_LPC_TPM
select NO_POST # This platform does not have any way to see POST codes
if BOARD_PURISM_BASEBOARD_LIBREM_SKL if BOARD_PURISM_BASEBOARD_LIBREM_SKL
@@ -54,12 +55,6 @@ config MAX_CPUS
int int
default 8 default 8
config NO_POST
def_bool y
help
This platform does not have any way to see POST codes
so disable them by default.
config VGA_BIOS_ID config VGA_BIOS_ID
string string
default "8086,1916" default "8086,1916"