sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

nb/intel/{i945,x4x,pineview}: Remove wrapper spd_read_byte()

Browse Source 
Change-Id: Ic9554ad2813ee70d0da16857d534aab5e17d808f
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/38213
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
This commit is contained in:
Kyösti Mälkki
2020-01-05 20:00:18 +02:00
parent 65f5de2bc4
commit bd65985a63
3 changed files with 4 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/northbridge/intel/i945/raminit.c
View File

@@ -62,11 +62,6 @@ static int get_dimm_spd_address(struct sys_info *sysinfo, int device)
}
static inline int spd_read_byte(unsigned int device, unsigned int address)
{
return smbus_read_byte(device, address);
}
static __attribute__((noinline)) void do_ram_command(u32 command)
{
u32 reg32;
@@ -365,7 +360,7 @@ static void gather_common_timing(struct sys_info *sysinfo,
if (!sdram_capabilities_dual_channel() && (i >> 1))
continue;
if (spd_read_byte(device, SPD_MEMORY_TYPE) !=
if (smbus_read_byte(device, SPD_MEMORY_TYPE) !=
SPD_MEMORY_TYPE_SDRAM_DDR2) {
printk(BIOS_DEBUG, "DDR II Channel %d Socket %d: N/A\n",
(i >> 1), (i & 1));
@@ -386,7 +381,7 @@ static void gather_common_timing(struct sys_info *sysinfo,
printk(BIOS_DEBUG, "i2c block operation failed,"
" trying smbus byte operation.\n");
for (j = 0; j < 64; j++)
raw_spd[j] = spd_read_byte(device, j);
raw_spd[j] = smbus_read_byte(device, j);
if (CONFIG(DEBUG_RAM_SETUP))
hexdump(raw_spd, 64);
}