sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

lib/gpio: constify array inputs

Browse Source 
The arrays of gpio_t are not manipulated in any way within the
gpio library. Add const to indicate that.

Change-Id: Ie32ab9de967ece22317e2b97b62e85b0757b910d
Signed-off-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-on: https://review.coreboot.org/22121
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
This commit is contained in:
Aaron Durbin
2017-10-20 10:31:15 -06:00
parent e8e72bd0ca
commit bd885c5bac
2 changed files with 12 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/include/gpio.h
View File

@@ -29,7 +29,7 @@ void gpio_input_pulldown(gpio_t gpio);
void gpio_input_pullup(gpio_t gpio); void gpio_input_pullup(gpio_t gpio);
void gpio_input(gpio_t gpio); void gpio_input(gpio_t gpio);
void gpio_output(gpio_t gpio, int value); void gpio_output(gpio_t gpio, int value);
int _gpio_base3_value(gpio_t gpio[], int num_gpio, int binary_first); int _gpio_base3_value(const gpio_t gpio[], int num_gpio, int binary_first);
/* /*
* This function may be implemented by SoC/board code to provide * This function may be implemented by SoC/board code to provide
@@ -60,9 +60,9 @@ uint16_t gpio_acpi_pin(gpio_t gpio);
* There are also pulldown and pullup variants which default each gpio to * There are also pulldown and pullup variants which default each gpio to
* be configured with an internal pulldown and pullup, respectively. * be configured with an internal pulldown and pullup, respectively.
*/ */
int gpio_base2_value(gpio_t gpio[], int num_gpio); int gpio_base2_value(const gpio_t gpio[], int num_gpio);
int gpio_pulldown_base2_value(gpio_t gpio[], int num_gpio); int gpio_pulldown_base2_value(const gpio_t gpio[], int num_gpio);
int gpio_pullup_base2_value(gpio_t gpio[], int num_gpio); int gpio_pullup_base2_value(const gpio_t gpio[], int num_gpio);
/* /*
* Read the value presented by the set of GPIOs, when each pin is interpreted * Read the value presented by the set of GPIOs, when each pin is interpreted
@@ -73,7 +73,7 @@ int gpio_pullup_base2_value(gpio_t gpio[], int num_gpio);
* gpio[]: pin positions to read. gpio[0] is less significant than gpio[1]. * gpio[]: pin positions to read. gpio[0] is less significant than gpio[1].
* num_gpio: number of pins to read. * num_gpio: number of pins to read.
*/ */
static inline int gpio_base3_value(gpio_t gpio[], int num_gpio) static inline int gpio_base3_value(const gpio_t gpio[], int num_gpio)
{ {
return _gpio_base3_value(gpio, num_gpio, 0); return _gpio_base3_value(gpio, num_gpio, 0);
} }
@@ -103,7 +103,8 @@ static inline int gpio_base3_value(gpio_t gpio[], int num_gpio)
* gpio[]: pin positions to read. gpio[0] is less significant than gpio[1]. * gpio[]: pin positions to read. gpio[0] is less significant than gpio[1].
* num_gpio: number of pins to read. * num_gpio: number of pins to read.
*/ */
static inline int gpio_binary_first_base3_value(gpio_t gpio[], int num_gpio) static inline int gpio_binary_first_base3_value(const gpio_t gpio[],
int num_gpio)
{ {
return _gpio_base3_value(gpio, num_gpio, 1); return _gpio_base3_value(gpio, num_gpio, 1);
} }

10
src/lib/gpio.c
View File

@@ -19,7 +19,7 @@
#include <delay.h> #include <delay.h>
#include <gpio.h> #include <gpio.h>
static int _gpio_base2_value(gpio_t gpio[], int num_gpio) static int _gpio_base2_value(const gpio_t gpio[], int num_gpio)
{ {
int i, result = 0; int i, result = 0;
@@ -32,7 +32,7 @@ static int _gpio_base2_value(gpio_t gpio[], int num_gpio)
return result; return result;
} }
int gpio_base2_value(gpio_t gpio[], int num_gpio) int gpio_base2_value(const gpio_t gpio[], int num_gpio)
{ {
int i; int i;
@@ -42,7 +42,7 @@ int gpio_base2_value(gpio_t gpio[], int num_gpio)
return _gpio_base2_value(gpio, num_gpio); return _gpio_base2_value(gpio, num_gpio);
} }
int gpio_pulldown_base2_value(gpio_t gpio[], int num_gpio) int gpio_pulldown_base2_value(const gpio_t gpio[], int num_gpio)
{ {
int i; int i;
@@ -52,7 +52,7 @@ int gpio_pulldown_base2_value(gpio_t gpio[], int num_gpio)
return _gpio_base2_value(gpio, num_gpio); return _gpio_base2_value(gpio, num_gpio);
} }
int gpio_pullup_base2_value(gpio_t gpio[], int num_gpio) int gpio_pullup_base2_value(const gpio_t gpio[], int num_gpio)
{ {
int i; int i;
@@ -62,7 +62,7 @@ int gpio_pullup_base2_value(gpio_t gpio[], int num_gpio)
return _gpio_base2_value(gpio, num_gpio); return _gpio_base2_value(gpio, num_gpio);
} }
int _gpio_base3_value(gpio_t gpio[], int num_gpio, int binary_first) int _gpio_base3_value(const gpio_t gpio[], int num_gpio, int binary_first)
{ {
/* /*
* GPIOs which are tied to stronger external pull up or pull down * GPIOs which are tied to stronger external pull up or pull down