sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

lib/thread: Allow nesting thread_cooperate and thread_prevent_coop

Browse Source 
This change allows nesting critical sections, and frees the caller from
having to keep track of whether the thread has coop enabled.


BUG=b:179699789
TEST=Boot guybrush with SPI DMA

Suggested-by: Julius Werner <jwerner@chromium.org>
Signed-off-by: Raul E Rangel <rrangel@chromium.org>
Change-Id: I325ab6181b17c5c084ca1e2c181b4df235020557
Reviewed-on: https://review.coreboot.org/c/coreboot/+/56350
Reviewed-by: Karthik Ramasubramanian <kramasub@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Raul E Rangel
2021-07-15 13:52:03 -06:00
committed by Raul Rangel
parent b95369c914
commit be60a0ddb0
2 changed files with 18 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/lib/thread.c
View File

@@ -31,7 +31,7 @@ static inline struct cpu_info *thread_cpu_info(const struct thread *t)
static inline int thread_can_yield(const struct thread *t)
{
return (t != NULL && t->can_yield);
return (t != NULL && t->can_yield > 0);
}
/* Assumes current CPU info can switch. */
@@ -358,8 +358,12 @@ void thread_cooperate(void)
current = current_thread();
if (current != NULL)
current->can_yield = 1;
if (current == NULL)
return;
assert(current->can_yield <= 0);
current->can_yield++;
}
void thread_prevent_coop(void)
@@ -368,6 +372,8 @@ void thread_prevent_coop(void)
current = current_thread();
if (current != NULL)
current->can_yield = 0;
if (current == NULL)
return;
current->can_yield--;
}