From be9cef9468169dbb7316cf5c96b9b372e1c94a91 Mon Sep 17 00:00:00 2001 From: Kane Chen Date: Thu, 12 May 2022 16:58:38 +0800 Subject: [PATCH] soc/intel/common: Consistently use smbus 7-bit address log format The "No memory dimm at address" line in get_spd_sn and get_spd fucntion have different format of SPD address. get_spd_sn shows a 8-bit address format but get_spd shows a 7-bit address format when there is no DIMM connected. It can be confusing when debugging. Change-Id: I46a006f4024b12d27ae0a933b7c40515034d5d64 Signed-off-by: Kane Chen Reviewed-on: https://review.coreboot.org/c/coreboot/+/64290 Tested-by: build bot (Jenkins) Reviewed-by: Jamie Chen Reviewed-by: Subrata Banik Reviewed-by: Eric Lai --- src/soc/intel/common/block/smbus/smbuslib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/soc/intel/common/block/smbus/smbuslib.c b/src/soc/intel/common/block/smbus/smbuslib.c index 17b63774de..a92f88018c 100644 --- a/src/soc/intel/common/block/smbus/smbuslib.c +++ b/src/soc/intel/common/block/smbus/smbuslib.c @@ -105,7 +105,7 @@ enum cb_err get_spd_sn(u8 addr, u32 *sn) /* If dimm is not present, set sn to 0xff. */ smbus_ret = smbus_read_byte(addr, SPD_DRAM_TYPE); if (smbus_ret < 0) { - printk(BIOS_INFO, "No memory dimm at address %02X\n", addr); + printk(BIOS_INFO, "No memory dimm at address %02X\n", addr << 1); *sn = 0xffffffff; return CB_SUCCESS; }