x86: use boot state callbacks to disable rom cache
On x86 systems there is a concept of cachings the ROM. However, the typical policy is that the boot cpu is the only one with it enabled. In order to ensure the MTRRs are the same across cores the rom cache needs to be disabled prior to OS resume or boot handoff. Therefore, utilize the boot state callbacks to schedule the disabling of the ROM cache at the ramstage exit points. Change-Id: I4da5886d9f1cf4c6af2f09bb909f0d0f0faa4e62 Signed-off-by: Aaron Durbin <adurbin@chromium.org> Reviewed-on: http://review.coreboot.org/3138 Tested-by: build bot (Jenkins) Reviewed-by: Ronald G. Minnich <rminnich@gmail.com>
This commit is contained in:
committed by
Ronald G. Minnich
parent
243aa44b74
commit
bebf66909a
@@ -27,6 +27,7 @@
|
||||
#include <stddef.h>
|
||||
#include <stdlib.h>
|
||||
#include <string.h>
|
||||
#include <bootstate.h>
|
||||
#include <console/console.h>
|
||||
#include <device/device.h>
|
||||
#include <cpu/cpu.h>
|
||||
@@ -408,10 +409,17 @@ void x86_mtrr_disable_rom_caching(void)
|
||||
enable_cache();
|
||||
}
|
||||
|
||||
void disable_cache_rom(void)
|
||||
static void disable_cache_rom(void *unused)
|
||||
{
|
||||
x86_mtrr_disable_rom_caching();
|
||||
}
|
||||
|
||||
BOOT_STATE_INIT_ENTRIES(disable_rom_cache_bscb) = {
|
||||
BOOT_STATE_INIT_ENTRY(BS_OS_RESUME, BS_ON_ENTRY,
|
||||
disable_cache_rom, NULL),
|
||||
BOOT_STATE_INIT_ENTRY(BS_PAYLOAD_LOAD, BS_ON_EXIT,
|
||||
disable_cache_rom, NULL),
|
||||
};
|
||||
#endif
|
||||
|
||||
struct var_mtrr_state {
|
||||
|
Reference in New Issue
Block a user