From bfa4225fdfef91bbf809e39d5942d3b500fb3807 Mon Sep 17 00:00:00 2001 From: Tim Crawford Date: Thu, 23 Jun 2022 08:59:48 -0600 Subject: [PATCH] mb/system76/adl-p: Fix SATA detection Change the FSP index for the SATA device to fix detection. Drop the internal pull-up as there is already an external pull-up. Change-Id: I5c97b3ee1f6208ca4e454647c8d19d7e7f025047 Signed-off-by: Tim Crawford --- src/mainboard/system76/adl-p/devicetree.cb | 4 ++-- src/mainboard/system76/adl-p/variants/darp8/gpio.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mainboard/system76/adl-p/devicetree.cb b/src/mainboard/system76/adl-p/devicetree.cb index e25035a042..d74a1f92fa 100644 --- a/src/mainboard/system76/adl-p/devicetree.cb +++ b/src/mainboard/system76/adl-p/devicetree.cb @@ -69,8 +69,8 @@ chip soc/intel/alderlake device ref heci1 on end device ref sata on - register "sata_ports_enable[0]" = "1" # SSD1 - register "sata_ports_dev_slp[0]" = "1" # GPP_H12 (SATA1_DEVSLP1) + register "sata_ports_enable[1]" = "1" # SSD1 + register "sata_ports_dev_slp[1]" = "1" # GPP_H12 (SATA1_DEVSLP1) end device ref pch_espi on register "gen1_dec" = "0x00040069" # EC PM channel diff --git a/src/mainboard/system76/adl-p/variants/darp8/gpio.c b/src/mainboard/system76/adl-p/variants/darp8/gpio.c index d44a558f70..271d49c4f5 100644 --- a/src/mainboard/system76/adl-p/variants/darp8/gpio.c +++ b/src/mainboard/system76/adl-p/variants/darp8/gpio.c @@ -31,7 +31,7 @@ static const struct pad_config gpio_table[] = { PAD_CFG_NF(GPP_A9, DN_20K, DEEP, NF1), // ESPI_CLK_EC PAD_CFG_NF(GPP_A10, NONE, DEEP, NF1), // ESPI_RESET_N PAD_NC(GPP_A11, NONE), - PAD_CFG_NF(GPP_A12, UP_20K, DEEP, NF1), // SATAGP1_SATA_SSD1 + PAD_CFG_NF(GPP_A12, NONE, DEEP, NF1), // SATAGP1_SATA_SSD1 PAD_CFG_GPO(GPP_A13, 1, PLTRST), // BT_EN PAD_NC(GPP_A14, NONE), PAD_NC(GPP_A15, NONE),