include/device/device.h: Remove CHIP_NAME() macro
Macros can be confusing on their own; hiding commas make things worse. This can sometimes be downright misleading. A "good" example would be the code in soc/intel/xeon_sp/spr/chip.c: CHIP_NAME("Intel SapphireRapids-SP").enable_dev = chip_enable_dev, This appears as CHIP_NAME() being some struct when in fact these are defining 2 separate members of the same struct. It was decided to remove this macro altogether, as it does not do anything special and incurs a maintenance burden. Change-Id: Iaed6dfb144bddcf5c43634b0c955c19afce388f0 Signed-off-by: Nicholas Sudsgaard <devel+coreboot@nsudsgaard.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/80239 Reviewed-by: Yidi Lin <yidilin@google.com> Reviewed-by: Felix Singer <service+coreboot-gerrit@felixsinger.de> Reviewed-by: Jakub Czapiga <czapiga@google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
This commit is contained in:
committed by
Felix Singer
parent
f4c496d3e3
commit
bfb11bec3b
@@ -17,6 +17,6 @@ static void ec_51nb_npce985la0dx_ops_enable(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations ec_51nb_npce985la0dx_ops = {
|
||||
CHIP_NAME("51NB EC")
|
||||
.name = "51NB EC",
|
||||
.enable_dev = ec_51nb_npce985la0dx_ops_enable,
|
||||
};
|
||||
|
@@ -123,6 +123,6 @@ static void enable_dev(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations ec_clevo_it5570e_ops = {
|
||||
CHIP_NAME("Clevo IT5570E EC")
|
||||
.name = "Clevo IT5570E EC",
|
||||
.enable_dev = enable_dev,
|
||||
};
|
||||
|
@@ -131,6 +131,6 @@ static void enable_dev(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations ec_compal_ene932_ops = {
|
||||
CHIP_NAME("COMPAL ENE932 EC")
|
||||
.name = "COMPAL ENE932 EC",
|
||||
.enable_dev = enable_dev
|
||||
};
|
||||
|
@@ -131,6 +131,6 @@ static void mec5035_enable(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations ec_dell_mec5035_ops = {
|
||||
CHIP_NAME("MEC5035 EC")
|
||||
.name = "MEC5035 EC",
|
||||
.enable_dev = mec5035_enable,
|
||||
};
|
||||
|
@@ -59,6 +59,6 @@ static void crosec_audio_codec_enable(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations ec_google_chromeec_audio_codec_ops = {
|
||||
CHIP_NAME("CrosEC Audio Codec Device")
|
||||
.name = "CrosEC Audio Codec Device",
|
||||
.enable_dev = crosec_audio_codec_enable
|
||||
};
|
||||
|
@@ -451,7 +451,7 @@ static void enable_dev(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations ec_google_chromeec_ops = {
|
||||
CHIP_NAME("Google Chrome EC")
|
||||
.name = "Google Chrome EC",
|
||||
.enable_dev = enable_dev,
|
||||
};
|
||||
|
||||
|
@@ -65,6 +65,6 @@ static void crosec_i2c_tunnel_enable(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations ec_google_chromeec_i2c_tunnel_ops = {
|
||||
CHIP_NAME("CrosEC I2C Tunnel Device")
|
||||
.name = "CrosEC I2C Tunnel Device",
|
||||
.enable_dev = crosec_i2c_tunnel_enable
|
||||
};
|
||||
|
@@ -52,6 +52,6 @@ static void conn_enable(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations ec_google_chromeec_mux_conn_ops = {
|
||||
CHIP_NAME("CrosEC Type C Mux device")
|
||||
.name = "CrosEC Type C Mux device",
|
||||
.enable_dev = conn_enable,
|
||||
};
|
||||
|
@@ -36,6 +36,6 @@ static void mux_enable(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations ec_google_chromeec_mux_ops = {
|
||||
CHIP_NAME("CrosEC Type C Mux device")
|
||||
.name = "CrosEC Type C Mux device",
|
||||
.enable_dev = mux_enable
|
||||
};
|
||||
|
@@ -230,6 +230,6 @@ static void wilco_ec_enable_dev(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations ec_google_wilco_ops = {
|
||||
CHIP_NAME("Google Wilco EC")
|
||||
.name = "Google Wilco EC",
|
||||
.enable_dev = wilco_ec_enable_dev,
|
||||
};
|
||||
|
@@ -120,6 +120,6 @@ static void kbc1126_enable(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations ec_hp_kbc1126_ops = {
|
||||
CHIP_NAME("SMSC KBC1126 for HP laptops")
|
||||
.name = "SMSC KBC1126 for HP laptops",
|
||||
.enable_dev = kbc1126_enable
|
||||
};
|
||||
|
@@ -239,6 +239,6 @@ static void it8516e_enable(struct device *dev)
|
||||
}
|
||||
|
||||
const struct chip_operations ec_kontron_it8516e_ops = {
|
||||
CHIP_NAME("Kontron (Fintec/ITE) IT8516E EC")
|
||||
.name = "Kontron (Fintec/ITE) IT8516E EC",
|
||||
.enable_dev = it8516e_enable
|
||||
};
|
||||
|
@@ -105,6 +105,6 @@ static void kempld_enable_dev(struct device *const dev)
|
||||
}
|
||||
|
||||
struct chip_operations ec_kontron_kempld_ops = {
|
||||
CHIP_NAME("Kontron KEMPLD")
|
||||
.name = "Kontron KEMPLD",
|
||||
.enable_dev = kempld_enable_dev,
|
||||
};
|
||||
|
@@ -325,6 +325,6 @@ static void h8_enable(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations ec_lenovo_h8_ops = {
|
||||
CHIP_NAME("Lenovo H8 EC")
|
||||
.name = "Lenovo H8 EC",
|
||||
.enable_dev = h8_enable,
|
||||
};
|
||||
|
@@ -126,6 +126,6 @@ static void enable_dev(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations ec_lenovo_pmh7_ops = {
|
||||
CHIP_NAME("Lenovo Power Management Hardware Hub 7")
|
||||
.name = "Lenovo Power Management Hardware Hub 7",
|
||||
.enable_dev = enable_dev,
|
||||
};
|
||||
|
@@ -141,6 +141,6 @@ static void enable_dev(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations ec_quanta_ene_kb3940q_ops = {
|
||||
CHIP_NAME("QUANTA EnE KB3940Q EC")
|
||||
.name = "QUANTA EnE KB3940Q EC",
|
||||
.enable_dev = enable_dev
|
||||
};
|
||||
|
@@ -154,6 +154,6 @@ static void enable_dev(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations ec_quanta_it8518_ops = {
|
||||
CHIP_NAME("QUANTA IT8518 EC")
|
||||
.name = "QUANTA IT8518 EC",
|
||||
.enable_dev = enable_dev
|
||||
};
|
||||
|
@@ -48,6 +48,6 @@ static void enable_dev(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations ec_roda_it8518_ops = {
|
||||
CHIP_NAME("Roda IT8518 EC")
|
||||
.name = "Roda IT8518 EC",
|
||||
.enable_dev = enable_dev
|
||||
};
|
||||
|
@@ -112,6 +112,6 @@ static void mec1308_enable(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations ec_smsc_mec1308_ops = {
|
||||
CHIP_NAME("SMSC MEC1308 EC Mailbox Interface")
|
||||
.name = "SMSC MEC1308 EC Mailbox Interface",
|
||||
.enable_dev = mec1308_enable
|
||||
};
|
||||
|
@@ -322,6 +322,6 @@ static void enable_dev(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations ec_starlabs_merlin_ops = {
|
||||
CHIP_NAME("ITE EC")
|
||||
.name = "ITE EC",
|
||||
.enable_dev = enable_dev
|
||||
};
|
||||
|
@@ -297,6 +297,6 @@ static void enable_dev(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations ec_starlabs_merlin_ops = {
|
||||
CHIP_NAME("NUVOTON EC")
|
||||
.name = "NUVOTON EC",
|
||||
.enable_dev = enable_dev
|
||||
};
|
||||
|
Reference in New Issue
Block a user