include/device/device.h: Remove CHIP_NAME() macro
Macros can be confusing on their own; hiding commas make things worse. This can sometimes be downright misleading. A "good" example would be the code in soc/intel/xeon_sp/spr/chip.c: CHIP_NAME("Intel SapphireRapids-SP").enable_dev = chip_enable_dev, This appears as CHIP_NAME() being some struct when in fact these are defining 2 separate members of the same struct. It was decided to remove this macro altogether, as it does not do anything special and incurs a maintenance burden. Change-Id: Iaed6dfb144bddcf5c43634b0c955c19afce388f0 Signed-off-by: Nicholas Sudsgaard <devel+coreboot@nsudsgaard.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/80239 Reviewed-by: Yidi Lin <yidilin@google.com> Reviewed-by: Felix Singer <service+coreboot-gerrit@felixsinger.de> Reviewed-by: Jakub Czapiga <czapiga@google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
This commit is contained in:
committed by
Felix Singer
parent
f4c496d3e3
commit
bfb11bec3b
@@ -59,6 +59,6 @@ static void crosec_audio_codec_enable(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations ec_google_chromeec_audio_codec_ops = {
|
||||
CHIP_NAME("CrosEC Audio Codec Device")
|
||||
.name = "CrosEC Audio Codec Device",
|
||||
.enable_dev = crosec_audio_codec_enable
|
||||
};
|
||||
|
@@ -451,7 +451,7 @@ static void enable_dev(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations ec_google_chromeec_ops = {
|
||||
CHIP_NAME("Google Chrome EC")
|
||||
.name = "Google Chrome EC",
|
||||
.enable_dev = enable_dev,
|
||||
};
|
||||
|
||||
|
@@ -65,6 +65,6 @@ static void crosec_i2c_tunnel_enable(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations ec_google_chromeec_i2c_tunnel_ops = {
|
||||
CHIP_NAME("CrosEC I2C Tunnel Device")
|
||||
.name = "CrosEC I2C Tunnel Device",
|
||||
.enable_dev = crosec_i2c_tunnel_enable
|
||||
};
|
||||
|
@@ -52,6 +52,6 @@ static void conn_enable(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations ec_google_chromeec_mux_conn_ops = {
|
||||
CHIP_NAME("CrosEC Type C Mux device")
|
||||
.name = "CrosEC Type C Mux device",
|
||||
.enable_dev = conn_enable,
|
||||
};
|
||||
|
@@ -36,6 +36,6 @@ static void mux_enable(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations ec_google_chromeec_mux_ops = {
|
||||
CHIP_NAME("CrosEC Type C Mux device")
|
||||
.name = "CrosEC Type C Mux device",
|
||||
.enable_dev = mux_enable
|
||||
};
|
||||
|
Reference in New Issue
Block a user