include/device/device.h: Remove CHIP_NAME() macro
Macros can be confusing on their own; hiding commas make things worse. This can sometimes be downright misleading. A "good" example would be the code in soc/intel/xeon_sp/spr/chip.c: CHIP_NAME("Intel SapphireRapids-SP").enable_dev = chip_enable_dev, This appears as CHIP_NAME() being some struct when in fact these are defining 2 separate members of the same struct. It was decided to remove this macro altogether, as it does not do anything special and incurs a maintenance burden. Change-Id: Iaed6dfb144bddcf5c43634b0c955c19afce388f0 Signed-off-by: Nicholas Sudsgaard <devel+coreboot@nsudsgaard.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/80239 Reviewed-by: Yidi Lin <yidilin@google.com> Reviewed-by: Felix Singer <service+coreboot-gerrit@felixsinger.de> Reviewed-by: Jakub Czapiga <czapiga@google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
This commit is contained in:
committed by
Felix Singer
parent
f4c496d3e3
commit
bfb11bec3b
@@ -103,6 +103,6 @@ static void enable_dev(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations superio_aspeed_ast2400_ops = {
|
||||
CHIP_NAME("ASpeed AST2400/AST2500 Super I/O")
|
||||
.name = "ASpeed AST2400/AST2500 Super I/O",
|
||||
.enable_dev = enable_dev,
|
||||
};
|
||||
|
@@ -324,6 +324,6 @@ static void enable_dev(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations superio_common_ops = {
|
||||
CHIP_NAME("Generic Super I/O")
|
||||
.name = "Generic Super I/O",
|
||||
.enable_dev = enable_dev,
|
||||
};
|
||||
|
@@ -51,6 +51,6 @@ static void enable_dev(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations superio_fintek_f71808a_ops = {
|
||||
CHIP_NAME("Fintek F71808A Super I/O")
|
||||
.name = "Fintek F71808A Super I/O",
|
||||
.enable_dev = enable_dev
|
||||
};
|
||||
|
@@ -33,6 +33,6 @@ static void enable_dev(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations superio_fintek_f71859_ops = {
|
||||
CHIP_NAME("Fintek F71859 Super I/O")
|
||||
.name = "Fintek F71859 Super I/O",
|
||||
.enable_dev = enable_dev
|
||||
};
|
||||
|
@@ -50,6 +50,6 @@ static void enable_dev(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations superio_fintek_f71863fg_ops = {
|
||||
CHIP_NAME("Fintek F71863FG Super I/O")
|
||||
.name = "Fintek F71863FG Super I/O",
|
||||
.enable_dev = enable_dev
|
||||
};
|
||||
|
@@ -107,6 +107,6 @@ static void enable_dev(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations superio_fintek_f71869ad_ops = {
|
||||
CHIP_NAME("Fintek F71869AD Super I/O")
|
||||
.name = "Fintek F71869AD Super I/O",
|
||||
.enable_dev = enable_dev
|
||||
};
|
||||
|
@@ -57,6 +57,6 @@ static void enable_dev(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations superio_fintek_f81803a_ops = {
|
||||
CHIP_NAME("Fintek F81803A Super I/O")
|
||||
.name = "Fintek F81803A Super I/O",
|
||||
.enable_dev = enable_dev
|
||||
};
|
||||
|
@@ -48,6 +48,6 @@ static void enable_dev(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations superio_fintek_f81865f_ops = {
|
||||
CHIP_NAME("Fintek F81865F Super I/O")
|
||||
.name = "Fintek F81865F Super I/O",
|
||||
.enable_dev = enable_dev
|
||||
};
|
||||
|
@@ -73,6 +73,6 @@ static void enable_dev(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations superio_fintek_f81866d_ops = {
|
||||
CHIP_NAME("Fintek F81866AD-I Super I/O")
|
||||
.name = "Fintek F81866AD-I Super I/O",
|
||||
.enable_dev = enable_dev
|
||||
};
|
||||
|
@@ -49,6 +49,6 @@ static void enable_dev(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations superio_ite_it8528e_ops = {
|
||||
CHIP_NAME("ITE IT8528E Super I/O")
|
||||
.name = "ITE IT8528E Super I/O",
|
||||
.enable_dev = enable_dev,
|
||||
};
|
||||
|
@@ -63,6 +63,6 @@ static void enable_dev(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations superio_ite_it8613e_ops = {
|
||||
CHIP_NAME("ITE IT8613E Super I/O")
|
||||
.name = "ITE IT8613E Super I/O",
|
||||
.enable_dev = enable_dev,
|
||||
};
|
||||
|
@@ -60,6 +60,6 @@ static void enable_dev(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations superio_ite_it8623e_ops = {
|
||||
CHIP_NAME("ITE IT8623E Super I/O")
|
||||
.name = "ITE IT8623E Super I/O",
|
||||
.enable_dev = enable_dev,
|
||||
};
|
||||
|
@@ -65,6 +65,6 @@ static void enable_dev(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations superio_ite_it8712f_ops = {
|
||||
CHIP_NAME("ITE IT8712F Super I/O")
|
||||
.name = "ITE IT8712F Super I/O",
|
||||
.enable_dev = enable_dev,
|
||||
};
|
||||
|
@@ -71,6 +71,6 @@ static void enable_dev(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations superio_ite_it8718f_ops = {
|
||||
CHIP_NAME("ITE IT8718F Super I/O")
|
||||
.name = "ITE IT8718F Super I/O",
|
||||
.enable_dev = enable_dev,
|
||||
};
|
||||
|
@@ -112,6 +112,6 @@ static void enable_dev(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations superio_ite_it8720f_ops = {
|
||||
CHIP_NAME("ITE IT8720F Super I/O")
|
||||
.name = "ITE IT8720F Super I/O",
|
||||
.enable_dev = enable_dev,
|
||||
};
|
||||
|
@@ -63,6 +63,6 @@ static void enable_dev(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations superio_ite_it8721f_ops = {
|
||||
CHIP_NAME("ITE IT8721F Super I/O")
|
||||
.name = "ITE IT8721F Super I/O",
|
||||
.enable_dev = enable_dev,
|
||||
};
|
||||
|
@@ -60,6 +60,6 @@ static void enable_dev(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations superio_ite_it8728f_ops = {
|
||||
CHIP_NAME("ITE IT8728F Super I/O")
|
||||
.name = "ITE IT8728F Super I/O",
|
||||
.enable_dev = enable_dev
|
||||
};
|
||||
|
@@ -268,6 +268,6 @@ static void enable_dev(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations superio_ite_it8772f_ops = {
|
||||
CHIP_NAME("ITE IT8772F Super I/O")
|
||||
.name = "ITE IT8772F Super I/O",
|
||||
.enable_dev = enable_dev,
|
||||
};
|
||||
|
@@ -88,6 +88,6 @@ static void enable_dev(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations superio_ite_it8783ef_ops = {
|
||||
CHIP_NAME("ITE IT8783E/F Super I/O")
|
||||
.name = "ITE IT8783E/F Super I/O",
|
||||
.enable_dev = enable_dev,
|
||||
};
|
||||
|
@@ -82,6 +82,6 @@ static void enable_dev(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations superio_ite_it8784e_ops = {
|
||||
CHIP_NAME("ITE IT8784E Super I/O")
|
||||
.name = "ITE IT8784E Super I/O",
|
||||
.enable_dev = enable_dev,
|
||||
};
|
||||
|
@@ -98,6 +98,6 @@ static void enable_dev(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations superio_ite_it8786e_ops = {
|
||||
CHIP_NAME("ITE IT8786E Super I/O")
|
||||
.name = "ITE IT8786E Super I/O",
|
||||
.enable_dev = enable_dev,
|
||||
};
|
||||
|
@@ -41,6 +41,6 @@ static void enable_dev(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations superio_nsc_pc87382_ops = {
|
||||
CHIP_NAME("NSC PC87382 Docking LPC Switch")
|
||||
.name = "NSC PC87382 Docking LPC Switch",
|
||||
.enable_dev = enable_dev,
|
||||
};
|
||||
|
@@ -25,6 +25,6 @@ static void enable_dev(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations superio_nsc_pc87384_ops = {
|
||||
CHIP_NAME("NSC PC87384 Super I/O")
|
||||
.name = "NSC PC87384 Super I/O",
|
||||
.enable_dev = enable_dev,
|
||||
};
|
||||
|
@@ -35,6 +35,6 @@ static void enable_dev(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations superio_nsc_pc87392_ops = {
|
||||
CHIP_NAME("NSC PC87392 Super I/O")
|
||||
.name = "NSC PC87392 Super I/O",
|
||||
.enable_dev = enable_dev,
|
||||
};
|
||||
|
@@ -46,6 +46,6 @@ static void enable_dev(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations superio_nsc_pc87417_ops = {
|
||||
CHIP_NAME("NSC PC87417 Super I/O")
|
||||
.name = "NSC PC87417 Super I/O",
|
||||
.enable_dev = enable_dev,
|
||||
};
|
||||
|
@@ -232,6 +232,6 @@ static void enable_dev(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations superio_nuvoton_nct5104d_ops = {
|
||||
CHIP_NAME("Nuvoton NCT5104D Super I/O")
|
||||
.name = "Nuvoton NCT5104D Super I/O",
|
||||
.enable_dev = enable_dev,
|
||||
};
|
||||
|
@@ -95,6 +95,6 @@ static void enable_dev(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations superio_nuvoton_nct5539d_ops = {
|
||||
CHIP_NAME("NUVOTON NCT5539D Super I/O")
|
||||
.name = "NUVOTON NCT5539D Super I/O",
|
||||
.enable_dev = enable_dev,
|
||||
};
|
||||
|
@@ -104,6 +104,6 @@ static void enable_dev(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations superio_nuvoton_nct5572d_ops = {
|
||||
CHIP_NAME("NUVOTON NCT5572D Super I/O")
|
||||
.name = "NUVOTON NCT5572D Super I/O",
|
||||
.enable_dev = enable_dev,
|
||||
};
|
||||
|
@@ -87,6 +87,6 @@ static void enable_dev(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations superio_nuvoton_nct6687d_ops = {
|
||||
CHIP_NAME("NUVOTON NCT6687D Super I/O")
|
||||
.name = "NUVOTON NCT6687D Super I/O",
|
||||
.enable_dev = enable_dev,
|
||||
};
|
||||
|
@@ -67,6 +67,6 @@ static void enable_dev(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations superio_nuvoton_nct6776_ops = {
|
||||
CHIP_NAME("NUVOTON NCT6776 Super I/O")
|
||||
.name = "NUVOTON NCT6776 Super I/O",
|
||||
.enable_dev = enable_dev,
|
||||
};
|
||||
|
@@ -62,6 +62,6 @@ static void enable_dev(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations superio_nuvoton_nct6779d_ops = {
|
||||
CHIP_NAME("NUVOTON NCT6779D Super I/O")
|
||||
.name = "NUVOTON NCT6779D Super I/O",
|
||||
.enable_dev = enable_dev,
|
||||
};
|
||||
|
@@ -102,6 +102,6 @@ static void enable_dev(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations superio_nuvoton_nct6791d_ops = {
|
||||
CHIP_NAME("NUVOTON NCT6791D Super I/O")
|
||||
.name = "NUVOTON NCT6791D Super I/O",
|
||||
.enable_dev = enable_dev,
|
||||
};
|
||||
|
@@ -460,6 +460,6 @@ static void enable_dev(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations superio_nuvoton_npcd378_ops = {
|
||||
CHIP_NAME("NUVOTON NPCD378 Super I/O")
|
||||
.name = "NUVOTON NPCD378 Super I/O",
|
||||
.enable_dev = enable_dev,
|
||||
};
|
||||
|
@@ -40,6 +40,6 @@ static void enable_dev(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations superio_nuvoton_wpcm450_ops = {
|
||||
CHIP_NAME("Nuvoton WPCM450 Super I/O")
|
||||
.name = "Nuvoton WPCM450 Super I/O",
|
||||
.enable_dev = enable_dev,
|
||||
};
|
||||
|
@@ -45,6 +45,6 @@ static void enable_dev(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations superio_renesas_m3885x_ops = {
|
||||
CHIP_NAME("Renesas M3885x Super I/O")
|
||||
.name = "Renesas M3885x Super I/O",
|
||||
.enable_dev = enable_dev,
|
||||
};
|
||||
|
@@ -46,6 +46,6 @@ static void enable_dev(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations superio_smsc_fdc37n972_ops = {
|
||||
CHIP_NAME("SMSC FDC37N972 Super I/O")
|
||||
.name = "SMSC FDC37N972 Super I/O",
|
||||
.enable_dev = enable_dev,
|
||||
};
|
||||
|
@@ -14,7 +14,7 @@ static void enable_dev(struct device *dev);
|
||||
static void kbc1100_init(struct device *dev);
|
||||
|
||||
struct chip_operations superio_smsc_kbc1100_ops = {
|
||||
CHIP_NAME("SMSC KBC1100 Super I/O")
|
||||
.name = "SMSC KBC1100 Super I/O",
|
||||
.enable_dev = enable_dev
|
||||
};
|
||||
|
||||
|
@@ -58,6 +58,6 @@ static void enable_dev(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations superio_smsc_lpc47m10x_ops = {
|
||||
CHIP_NAME("SMSC LPC47M10x Super I/O")
|
||||
.name = "SMSC LPC47M10x Super I/O",
|
||||
.enable_dev = enable_dev
|
||||
};
|
||||
|
@@ -14,7 +14,7 @@ static void enable_dev(struct device *dev);
|
||||
static void lpc47m15x_init(struct device *dev);
|
||||
|
||||
struct chip_operations superio_smsc_lpc47m15x_ops = {
|
||||
CHIP_NAME("SMSC LPC47M15x/192/997 Super I/O")
|
||||
.name = "SMSC LPC47M15x/192/997 Super I/O",
|
||||
.enable_dev = enable_dev
|
||||
};
|
||||
|
||||
|
@@ -25,7 +25,7 @@ static void pnp_enter_conf_state(struct device *dev);
|
||||
static void pnp_exit_conf_state(struct device *dev);
|
||||
|
||||
struct chip_operations superio_smsc_lpc47n217_ops = {
|
||||
CHIP_NAME("SMSC LPC47N217 Super I/O")
|
||||
.name = "SMSC LPC47N217 Super I/O",
|
||||
.enable_dev = enable_dev,
|
||||
};
|
||||
|
||||
|
@@ -24,7 +24,7 @@ void lpc47n227_pnp_set_irq(struct device *dev, u8 irq);
|
||||
void lpc47n227_pnp_set_enable(struct device *dev, int enable);
|
||||
|
||||
struct chip_operations superio_smsc_lpc47n227_ops = {
|
||||
CHIP_NAME("SMSC LPC47N227 Super I/O")
|
||||
.name = "SMSC LPC47N227 Super I/O",
|
||||
.enable_dev = enable_dev,
|
||||
};
|
||||
|
||||
|
@@ -47,6 +47,6 @@ static void enable_dev(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations superio_smsc_mec1308_ops = {
|
||||
CHIP_NAME("SMSC MEC1308 EC SuperIO Interface")
|
||||
.name = "SMSC MEC1308 EC SuperIO Interface",
|
||||
.enable_dev = enable_dev
|
||||
};
|
||||
|
@@ -303,6 +303,6 @@ static void enable_dev(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations superio_smsc_sch5545_ops = {
|
||||
CHIP_NAME("SMSC SCH5545 Super I/O")
|
||||
.name = "SMSC SCH5545 Super I/O",
|
||||
.enable_dev = enable_dev,
|
||||
};
|
||||
|
@@ -136,6 +136,6 @@ static void sch555x_enable_dev(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations superio_smsc_sch555x_ops = {
|
||||
CHIP_NAME("SMSC SCH555x Super I/O")
|
||||
.name = "SMSC SCH555x Super I/O",
|
||||
.enable_dev = sch555x_enable_dev,
|
||||
};
|
||||
|
@@ -33,6 +33,6 @@ static void enable_dev(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations superio_smsc_sio1036_ops = {
|
||||
CHIP_NAME("SMSC SIO1036 Super I/O")
|
||||
.name = "SMSC SIO1036 Super I/O",
|
||||
.enable_dev = enable_dev
|
||||
};
|
||||
|
@@ -43,6 +43,6 @@ static void enable_dev(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations superio_smsc_sio10n268_ops = {
|
||||
CHIP_NAME("SMSC SIO10N268 Super I/O")
|
||||
.name = "SMSC SIO10N268 Super I/O",
|
||||
.enable_dev = enable_dev,
|
||||
};
|
||||
|
@@ -281,6 +281,6 @@ static void enable_dev(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations superio_smsc_smscsuperio_ops = {
|
||||
CHIP_NAME("Various SMSC Super I/Os")
|
||||
.name = "Various SMSC Super I/Os",
|
||||
.enable_dev = enable_dev
|
||||
};
|
||||
|
@@ -68,6 +68,6 @@ static void enable_dev(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations superio_winbond_w83627dhg_ops = {
|
||||
CHIP_NAME("Winbond W83627DHG Super I/O")
|
||||
.name = "Winbond W83627DHG Super I/O",
|
||||
.enable_dev = enable_dev,
|
||||
};
|
||||
|
@@ -129,6 +129,6 @@ static void enable_dev(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations superio_winbond_w83627ehg_ops = {
|
||||
CHIP_NAME("Winbond W83627EHG Super I/O")
|
||||
.name = "Winbond W83627EHG Super I/O",
|
||||
.enable_dev = enable_dev,
|
||||
};
|
||||
|
@@ -129,6 +129,6 @@ static void enable_dev(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations superio_winbond_w83627hf_ops = {
|
||||
CHIP_NAME("Winbond W83627HF Super I/O")
|
||||
.name = "Winbond W83627HF Super I/O",
|
||||
.enable_dev = enable_dev,
|
||||
};
|
||||
|
@@ -50,6 +50,6 @@ static void enable_dev(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations superio_winbond_w83627thg_ops = {
|
||||
CHIP_NAME("Winbond W83627THG Super I/O")
|
||||
.name = "Winbond W83627THG Super I/O",
|
||||
.enable_dev = enable_dev,
|
||||
};
|
||||
|
@@ -101,6 +101,6 @@ static void enable_dev(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations superio_winbond_w83627uhg_ops = {
|
||||
CHIP_NAME("Winbond W83627UHG Super I/O")
|
||||
.name = "Winbond W83627UHG Super I/O",
|
||||
.enable_dev = enable_dev,
|
||||
};
|
||||
|
@@ -103,6 +103,6 @@ static void enable_dev(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations superio_winbond_w83667hg_a_ops = {
|
||||
CHIP_NAME("WINBOND W83667HG-A Super I/O")
|
||||
.name = "WINBOND W83667HG-A Super I/O",
|
||||
.enable_dev = enable_dev,
|
||||
};
|
||||
|
@@ -50,6 +50,6 @@ static void enable_dev(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations superio_winbond_w83977tf_ops = {
|
||||
CHIP_NAME("Winbond W83977TF Super I/O")
|
||||
.name = "Winbond W83977TF Super I/O",
|
||||
.enable_dev = enable_dev,
|
||||
};
|
||||
|
@@ -61,6 +61,6 @@ static void enable_dev(struct device *dev)
|
||||
}
|
||||
|
||||
struct chip_operations superio_winbond_wpcd376i_ops = {
|
||||
CHIP_NAME("Winbond WPCD376I Super I/O")
|
||||
.name = "Winbond WPCD376I Super I/O",
|
||||
.enable_dev = enable_dev,
|
||||
};
|
||||
|
Reference in New Issue
Block a user