sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

sb/intel/common: Rename i2c_block_read() to i2c_eeprom_read()

Browse Source 
Datasheets describe the used command as 'I2C Read' but adding the
word 'eeprom' in between should avoid further confusion with other
block commands.

Followups will add a symmetrical pair of commands i2c_block_read()
and i2c_block_write() that operate via I2C_EN bit and have a 32
byte size restriction on block transfers. For some hardware revision
these block commands are available, while 'I2C Read' was not.

Change-Id: I4494ab2985afc7f737ddacc8d706a5d5395e35cf
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/31151
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
This commit is contained in:
Kyösti Mälkki
2019-01-30 09:39:23 +02:00
parent 757571eec1
commit c01a505282
9 changed files with 25 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/southbridge/intel/common/smbus.c
View File

@@ -363,11 +363,22 @@ int do_smbus_block_write(unsigned int smbus_base, u8 device, u8 cmd,
}
/* Only since ICH5 */
int do_i2c_block_read(unsigned int smbus_base, u8 device,
static int has_i2c_read_command(void)
{
if (IS_ENABLED(CONFIG_SOUTHBRIDGE_INTEL_I82371EB) ||
IS_ENABLED(CONFIG_SOUTHBRIDGE_INTEL_I82801DX))
return 0;
return 1;
}
int do_i2c_eeprom_read(unsigned int smbus_base, u8 device,
unsigned int offset, const unsigned int bytes, u8 *buf)
{
int ret;
if (!has_i2c_read_command())
return SMBUS_ERROR;
/* Set up for a i2c block data read.
*
* FIXME: Address parameter changes to XMIT_READ(device) with