sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Revert "sb/intel/common/acpi: Add more Windows versions"

Browse Source 
This reverts commit cc805d9dd64ca2d3c8de2b2de2ea7c53b387ff8f.

Advertising certain Windows versions triggers different paths in
the OS. As there may also be device specific quirks in the OS, such
changes need to be tested thoroughly on all affected devices.

There was at least one very subtle regression introduced by this.
When Linux sees "Windows 2012" support advertised, it disables the
`acpi_video` backlight controls, at least on devices with Intel IGD.
Without user-space handling the ACPI events, keyboard backlight
controls stop working.

Moreover, the commit message didn't state any reason for this change.
Why was it merged?

Change-Id: I722075f8e8f836b039fb8b8277e665fb49dac8f4
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/41192
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
This commit is contained in:
Nico Huber 2020-05-10 12:27:32 +02:00 committed by Patrick Georgi
parent a3a71c64ab
commit c08bf025f7
1 changed files with 2 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
src/southbridge/intel/common/acpi/platform.asl
View File

@ -47,16 +47,10 @@ Method(GOS, 0)
* OSYS value | Operating System * OSYS value | Operating System
* -----------+------------------ * -----------+------------------
* 2000 | Windows 2000 * 2000 | Windows 2000
* 2001 | Windows XP * 2001 | Windows XP(+SP1)
* 2001 | Windows XP SP1
* 2001 | Windows Server 2003
* 2001 | Windows Server 2003 SP1
* 2002 | Windows XP SP2 * 2002 | Windows XP SP2
* 2006 | Windows Vista * 2006 | Windows Vista
* 2006 | Windows Vista SP1 * ???? | Windows 7
* 2006 | Windows Server 2008
* 2009 | Windows 7
* 2012 | Windows 8
*/ */
/* Let's assume we're running at least Windows 2000 */ /* Let's assume we're running at least Windows 2000 */
@ -71,14 +65,6 @@ Method(GOS, 0)
Store (2001, OSYS) Store (2001, OSYS)
} }
If (_OSI("Windows 2001.1")) {
Store (2001, OSYS)
}
If (_OSI("Windows 2001.1 SP1")) {
Store (2001, OSYS)
}
If (_OSI("Windows 2001 SP2")) { If (_OSI("Windows 2001 SP2")) {
Store (2002, OSYS) Store (2002, OSYS)
} }
@ -86,21 +72,5 @@ Method(GOS, 0)
If (_OSI("Windows 2006")) { If (_OSI("Windows 2006")) {
Store (2006, OSYS) Store (2006, OSYS)
} }
If (_OSI("Windows 2006 SP1")) {
Store (2006, OSYS)
}
If (_OSI("Windows 2006.1")) {
Store (2006, OSYS)
}
If (_OSI("Windows 2009")) {
Store (2009, OSYS)
}
If (_OSI("Windows 2012")) {
Store (2012, OSYS)
}
} }
} }