sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cbfstool: Deserialize CBFS master header when reading image

Browse Source 
Rather than  using [hn]to[nh] whenever accessing a member of the CBFS
header, deserialize the header when opening the CBFS image. The header
is no longer a pointer inside the CBFS buffer, but a separate struct,
a copy of the original header in a host-friendly format. This kills
more of the ntohl usage.

Change-Id: I5f8a5818b9d5a2d1152b1906249c4a5847d02bac
Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Reviewed-on: http://review.coreboot.org/5121
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Ronald G. Minnich <rminnich@gmail.com>
This commit is contained in:
Alexandru Gagniuc
2014-02-05 01:10:08 -06:00
parent 2516f2e467
commit c1d1fd850e
3 changed files with 58 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
util/cbfstool/cbfstool.c
View File

@@ -436,7 +436,7 @@ static int cbfs_locate(void)
}
if (param.top_aligned)
address = address - ntohl(image.header->romsize);
address = address - image.header->romsize;
cbfs_image_delete(&image);
printf("0x%x\n", address);