sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

tegra210: Remove fake cpu_reset()

Browse Source 
The Tegra210 SoC never had a proper cpu_reset() implementation, so it's
pointless to pretend there is one. Most ARM SoCs/boards only define
hard_reset() at the moment anyway, so let's stick with that.

Change-Id: I40f39921fa99d6dfabf818e7abe7a5732341cf4f
Signed-off-by: Julius Werner <jwerner@chromium.org>
Reviewed-on: https://review.coreboot.org/19786
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Philippe Mathieu-Daudé <philippe.mathieu.daude@gmail.com>
This commit is contained in:
Julius Werner 2017-04-14 15:39:23 -07:00
parent baa3e70084
commit c25b2a18fa
4 changed files with 4 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/mainboard/google/foster/pmic.c
View File

@ -43,8 +43,8 @@ static void pmic_write_reg(unsigned bus, uint8_t reg, uint8_t val, int delay)
if (i2c_writeb(bus, MAX77620_I2C_ADDR, reg, val)) { if (i2c_writeb(bus, MAX77620_I2C_ADDR, reg, val)) {
printk(BIOS_ERR, "%s: reg = 0x%02X, value = 0x%02X failed!\n", printk(BIOS_ERR, "%s: reg = 0x%02X, value = 0x%02X failed!\n",
__func__, reg, val); __func__, reg, val);
/* Reset the SoC on any PMIC write error */ /* Reset the board on any PMIC write error */
cpu_reset(); hard_reset();
} else { } else {
if (delay) if (delay)
udelay(500); udelay(500);

4
src/mainboard/google/smaug/pmic.c
View File

@ -46,8 +46,8 @@ static void pmic_write_reg(unsigned bus, uint8_t chip, uint8_t reg, uint8_t val,
if (i2c_writeb(bus, chip, reg, val)) { if (i2c_writeb(bus, chip, reg, val)) {
printk(BIOS_ERR, "%s: reg = 0x%02X, value = 0x%02X failed!\n", printk(BIOS_ERR, "%s: reg = 0x%02X, value = 0x%02X failed!\n",
__func__, reg, val); __func__, reg, val);
/* Reset the SoC on any PMIC write error */ /* Reset the board on any PMIC write error */
cpu_reset(); hard_reset();
} else { } else {
if (delay) if (delay)
udelay(500); udelay(500);

3
src/soc/nvidia/tegra210/Makefile.inc
View File

@ -12,7 +12,6 @@ bootblock-y += monotonic_timer.c
bootblock-y += padconfig.c bootblock-y += padconfig.c
bootblock-y += power.c bootblock-y += power.c
bootblock-y += funitcfg.c bootblock-y += funitcfg.c
bootblock-y += reset.c
bootblock-y += ../tegra/gpio.c bootblock-y += ../tegra/gpio.c
bootblock-y += ../tegra/i2c.c bootblock-y += ../tegra/i2c.c
bootblock-y += ../tegra/pingroup.c bootblock-y += ../tegra/pingroup.c
@ -41,7 +40,6 @@ romstage-y += cbmem.c
romstage-y += ccplex.c romstage-y += ccplex.c
romstage-y += clock.c romstage-y += clock.c
romstage-y += cpu.c romstage-y += cpu.c
romstage-y += reset.c
romstage-y += spi.c romstage-y += spi.c
romstage-y += i2c.c romstage-y += i2c.c
romstage-y += dma.c romstage-y += dma.c
@ -87,7 +85,6 @@ ramstage-y += gic.c
ramstage-y += monotonic_timer.c ramstage-y += monotonic_timer.c
ramstage-y += padconfig.c ramstage-y += padconfig.c
ramstage-y += funitcfg.c ramstage-y += funitcfg.c
ramstage-y += reset.c
ramstage-y += ram_code.c ramstage-y += ram_code.c
ramstage-y += ../tegra/apbmisc.c ramstage-y += ../tegra/apbmisc.c
ramstage-y += ../tegra/gpio.c ramstage-y += ../tegra/gpio.c

25
src/soc/nvidia/tegra210/reset.c
View File

@ -1,25 +0,0 @@
/*
* This file is part of the coreboot project.
*
* Copyright 2014 Google Inc.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; version 2 of the License.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*/
#include <reset.h>
/*
* Promote cpu_reset() to a hard_reset(). A shallower reset can be added,
* if needed, at a later time.
*/
void cpu_reset(void)
{
hard_reset();
}