sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

nb/intel/ironlake/raminit_heci.c: Turn into compilation unit

Browse Source 
Remove the temporary `raminit_heci.c` include and make it a proper
compilation unit. Export the `setup_heci_uma()` function.

Change-Id: Ia6782a0cb5e731d58764d0fa4ee256bfc8cef98a
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/61929
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
This commit is contained in:
Angel Pons
2022-02-14 12:39:41 +01:00
committed by Felix Held
parent 4e722d0766
commit c35ce0e2a6
4 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/northbridge/intel/ironlake/Makefile.inc
View File

@ -11,6 +11,7 @@ ramstage-y += gma.c
romstage-y += memmap.c romstage-y += memmap.c
romstage-y += raminit.c romstage-y += raminit.c
romstage-y += raminit_heci.c
romstage-y += raminit_tables.c romstage-y += raminit_tables.c
romstage-y += early_init.c romstage-y += early_init.c
romstage-y += romstage.c romstage-y += romstage.c

3
src/northbridge/intel/ironlake/raminit.c
View File

@ -1503,9 +1503,6 @@ static const struct ram_training *get_cached_training(void)
NULL); NULL);
} }
/* TODO: Remove */
#include "raminit_heci.c"
static int have_match_ranks(struct raminfo *info, int channel, int ranks) static int have_match_ranks(struct raminfo *info, int channel, int ranks)
{ {
int ranks_in_channel; int ranks_in_channel;

2
src/northbridge/intel/ironlake/raminit.h
View File

@ -106,4 +106,6 @@ u16 get_max_timing(struct raminfo *info, int channel);
void early_quickpath_init(struct raminfo *info, const u8 x2ca8); void early_quickpath_init(struct raminfo *info, const u8 x2ca8);
void late_quickpath_init(struct raminfo *info, const int s3resume); void late_quickpath_init(struct raminfo *info, const int s3resume);
void setup_heci_uma(struct raminfo *info);
#endif /* RAMINIT_H */ #endif /* RAMINIT_H */

2
src/northbridge/intel/ironlake/raminit_heci.c
View File

@ -193,7 +193,7 @@ static void send_heci_uma_message(const u64 heci_uma_addr, const unsigned int he
die("HECI init failed\n"); die("HECI init failed\n");
} }
static void setup_heci_uma(struct raminfo *info) void setup_heci_uma(struct raminfo *info)
{ {
if (!info->memory_reserved_for_heci_mb && !(pci_read_config32(HECIDEV, 0x40) & 0x20)) if (!info->memory_reserved_for_heci_mb && !(pci_read_config32(HECIDEV, 0x40) & 0x20))
return; return;