soc/intel/common/block: Use readXXp/writeXXp()
Change-Id: I83d05ce0b26b01fdfc95d1442a4c930ed77bf25c Signed-off-by: Elyes Haouas <ehaouas@noos.fr> Reviewed-on: https://review.coreboot.org/c/coreboot/+/70294 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Sridhar Siricilla <sridhar.siricilla@intel.com> Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
This commit is contained in:
		@@ -42,7 +42,7 @@ static uint32_t fast_spi_flash_ctrlr_reg_read(struct fast_spi_flash_ctx *ctx,
 | 
				
			|||||||
	uint16_t reg)
 | 
						uint16_t reg)
 | 
				
			||||||
{
 | 
					{
 | 
				
			||||||
	uintptr_t addr =  ALIGN_DOWN(ctx->mmio_base + reg, sizeof(uint32_t));
 | 
						uintptr_t addr =  ALIGN_DOWN(ctx->mmio_base + reg, sizeof(uint32_t));
 | 
				
			||||||
	return read32((void *)addr);
 | 
						return read32p(addr);
 | 
				
			||||||
}
 | 
					}
 | 
				
			||||||
 | 
					
 | 
				
			||||||
/* Write to register in FAST_SPI flash controller. */
 | 
					/* Write to register in FAST_SPI flash controller. */
 | 
				
			||||||
@@ -50,7 +50,7 @@ static void fast_spi_flash_ctrlr_reg_write(struct fast_spi_flash_ctx *ctx,
 | 
				
			|||||||
					uint16_t reg, uint32_t val)
 | 
										uint16_t reg, uint32_t val)
 | 
				
			||||||
{
 | 
					{
 | 
				
			||||||
	uintptr_t addr =  ALIGN_DOWN(ctx->mmio_base + reg, sizeof(uint32_t));
 | 
						uintptr_t addr =  ALIGN_DOWN(ctx->mmio_base + reg, sizeof(uint32_t));
 | 
				
			||||||
	write32((void *)addr, val);
 | 
						write32p(addr, val);
 | 
				
			||||||
}
 | 
					}
 | 
				
			||||||
 | 
					
 | 
				
			||||||
/*
 | 
					/*
 | 
				
			||||||
@@ -378,7 +378,7 @@ static int fast_spi_flash_protect(const struct spi_flash *flash,
 | 
				
			|||||||
 | 
					
 | 
				
			||||||
	/* Find first empty FPR */
 | 
						/* Find first empty FPR */
 | 
				
			||||||
	for (fpr = 0; fpr < SPIBAR_FPR_MAX; fpr++) {
 | 
						for (fpr = 0; fpr < SPIBAR_FPR_MAX; fpr++) {
 | 
				
			||||||
		reg = read32((void *)fpr_base);
 | 
							reg = read32p(fpr_base);
 | 
				
			||||||
		if (reg == 0)
 | 
							if (reg == 0)
 | 
				
			||||||
			break;
 | 
								break;
 | 
				
			||||||
		fpr_base += sizeof(uint32_t);
 | 
							fpr_base += sizeof(uint32_t);
 | 
				
			||||||
@@ -408,8 +408,8 @@ static int fast_spi_flash_protect(const struct spi_flash *flash,
 | 
				
			|||||||
	reg = SPI_FPR(start, end) | protect_mask;
 | 
						reg = SPI_FPR(start, end) | protect_mask;
 | 
				
			||||||
 | 
					
 | 
				
			||||||
	/* Set the FPR register and verify it is protected */
 | 
						/* Set the FPR register and verify it is protected */
 | 
				
			||||||
	write32((void *)fpr_base, reg);
 | 
						write32p(fpr_base, reg);
 | 
				
			||||||
	reg = read32((void *)fpr_base);
 | 
						reg = read32p(fpr_base);
 | 
				
			||||||
	if (!(reg & protect_mask)) {
 | 
						if (!(reg & protect_mask)) {
 | 
				
			||||||
		printk(BIOS_ERR, "Unable to set SPI FPR %d\n", fpr);
 | 
							printk(BIOS_ERR, "Unable to set SPI FPR %d\n", fpr);
 | 
				
			||||||
		return -1;
 | 
							return -1;
 | 
				
			||||||
 
 | 
				
			|||||||
@@ -148,12 +148,12 @@ static uintptr_t graphics_get_gtt_base(void)
 | 
				
			|||||||
 | 
					
 | 
				
			||||||
uint32_t graphics_gtt_read(unsigned long reg)
 | 
					uint32_t graphics_gtt_read(unsigned long reg)
 | 
				
			||||||
{
 | 
					{
 | 
				
			||||||
	return read32((void *)(graphics_get_gtt_base() + reg));
 | 
						return read32p(graphics_get_gtt_base() + reg);
 | 
				
			||||||
}
 | 
					}
 | 
				
			||||||
 | 
					
 | 
				
			||||||
void graphics_gtt_write(unsigned long reg, uint32_t data)
 | 
					void graphics_gtt_write(unsigned long reg, uint32_t data)
 | 
				
			||||||
{
 | 
					{
 | 
				
			||||||
	write32((void *)(graphics_get_gtt_base() + reg), data);
 | 
						write32p(graphics_get_gtt_base() + reg, data);
 | 
				
			||||||
}
 | 
					}
 | 
				
			||||||
 | 
					
 | 
				
			||||||
void graphics_gtt_rmw(unsigned long reg, uint32_t andmask, uint32_t ormask)
 | 
					void graphics_gtt_rmw(unsigned long reg, uint32_t andmask, uint32_t ormask)
 | 
				
			||||||
 
 | 
				
			|||||||
@@ -283,14 +283,14 @@ static uint32_t gspi_read_mmio_reg(const struct gspi_ctrlr_params *p,
 | 
				
			|||||||
					uint32_t offset)
 | 
										uint32_t offset)
 | 
				
			||||||
{
 | 
					{
 | 
				
			||||||
	assert(p->mmio_base != 0);
 | 
						assert(p->mmio_base != 0);
 | 
				
			||||||
	return read32((void *)(p->mmio_base + offset));
 | 
						return read32p(p->mmio_base + offset);
 | 
				
			||||||
}
 | 
					}
 | 
				
			||||||
 | 
					
 | 
				
			||||||
static void gspi_write_mmio_reg(const struct gspi_ctrlr_params *p,
 | 
					static void gspi_write_mmio_reg(const struct gspi_ctrlr_params *p,
 | 
				
			||||||
				uint32_t offset, uint32_t value)
 | 
									uint32_t offset, uint32_t value)
 | 
				
			||||||
{
 | 
					{
 | 
				
			||||||
	assert(p->mmio_base != 0);
 | 
						assert(p->mmio_base != 0);
 | 
				
			||||||
	write32((void *)(p->mmio_base + offset), value);
 | 
						write32p(p->mmio_base + offset, value);
 | 
				
			||||||
}
 | 
					}
 | 
				
			||||||
 | 
					
 | 
				
			||||||
static int gspi_ctrlr_params_init(struct gspi_ctrlr_params *p,
 | 
					static int gspi_ctrlr_params_init(struct gspi_ctrlr_params *p,
 | 
				
			||||||
 
 | 
				
			|||||||
@@ -97,8 +97,8 @@ void sa_set_mch_bar(const struct sa_mmio_descriptor *fixed_set_resources,
 | 
				
			|||||||
		base = fixed_set_resources[i].base;
 | 
							base = fixed_set_resources[i].base;
 | 
				
			||||||
		index = fixed_set_resources[i].index;
 | 
							index = fixed_set_resources[i].index;
 | 
				
			||||||
		if (base >> 32)
 | 
							if (base >> 32)
 | 
				
			||||||
			write32((void *)(uintptr_t)(MCH_BASE_ADDRESS + index + 4), base >> 32);
 | 
								write32p((uintptr_t)(MCH_BASE_ADDRESS + index + 4), base >> 32);
 | 
				
			||||||
		write32((void *)(uintptr_t)(MCH_BASE_ADDRESS + index),
 | 
							write32p((uintptr_t)(MCH_BASE_ADDRESS + index),
 | 
				
			||||||
			(base & 0xffffffff) | PCIEXBAR_PCIEXBAREN);
 | 
								(base & 0xffffffff) | PCIEXBAR_PCIEXBAREN);
 | 
				
			||||||
	}
 | 
						}
 | 
				
			||||||
}
 | 
					}
 | 
				
			||||||
 
 | 
				
			|||||||
@@ -29,7 +29,7 @@ static bool xhci_port_wake_check(uintptr_t base, uint8_t num, uint8_t host_event
 | 
				
			|||||||
 | 
					
 | 
				
			||||||
	for (i = 0; i < num; i++, base += 0x10) {
 | 
						for (i = 0; i < num; i++, base += 0x10) {
 | 
				
			||||||
		/* Read port status and control register for the port. */
 | 
							/* Read port status and control register for the port. */
 | 
				
			||||||
		port_status = read32((void *)base);
 | 
							port_status = read32p(base);
 | 
				
			||||||
 | 
					
 | 
				
			||||||
		/* Ensure that the status is not all 1s. */
 | 
							/* Ensure that the status is not all 1s. */
 | 
				
			||||||
		if (port_status == 0xffffffff)
 | 
							if (port_status == 0xffffffff)
 | 
				
			||||||
 
 | 
				
			|||||||
@@ -3,6 +3,7 @@
 | 
				
			|||||||
#include <acpi/acpi_device.h>
 | 
					#include <acpi/acpi_device.h>
 | 
				
			||||||
#include <console/console.h>
 | 
					#include <console/console.h>
 | 
				
			||||||
#include <device/device.h>
 | 
					#include <device/device.h>
 | 
				
			||||||
 | 
					#include <device/mmio.h>
 | 
				
			||||||
#include <device/pci.h>
 | 
					#include <device/pci.h>
 | 
				
			||||||
#include <device/pci_ids.h>
 | 
					#include <device/pci_ids.h>
 | 
				
			||||||
#include <drivers/usb/acpi/chip.h>
 | 
					#include <drivers/usb/acpi/chip.h>
 | 
				
			||||||
@@ -68,7 +69,7 @@ static bool is_usb_port_connected(const struct xhci_usb_info *info,
 | 
				
			|||||||
	else
 | 
						else
 | 
				
			||||||
		port_sts_reg = (uintptr_t)res->base +
 | 
							port_sts_reg = (uintptr_t)res->base +
 | 
				
			||||||
				info->usb3_port_status_reg + port_id * 0x10;
 | 
									info->usb3_port_status_reg + port_id * 0x10;
 | 
				
			||||||
	port_status = read32((void *)port_sts_reg);
 | 
						port_status = read32p(port_sts_reg);
 | 
				
			||||||
 | 
					
 | 
				
			||||||
	/* Ensure that the status is not all 1s */
 | 
						/* Ensure that the status is not all 1s */
 | 
				
			||||||
	if (port_status == 0xffffffff)
 | 
						if (port_status == 0xffffffff)
 | 
				
			||||||
 
 | 
				
			|||||||
		Reference in New Issue
	
	Block a user