soc/intel: Treat time-out as failure in HECI
If HECI gets times out when waiting for read slots, there's no need to read back reply message to decide if the HECI recieve successed or not. Otherwise, system will stuck after global reset required. BUG=b:707290799 TEST=Boot up meowth board without battery, and confirm hard reset got trigged after heci time out. Change-Id: I7c1655284d7027294d8ff5d6a5dbbebe4cbd0c47 Signed-off-by: Lijian Zhao <lijian.zhao@intel.com> Reviewed-on: https://review.coreboot.org/22910 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Aaron Durbin <adurbin@chromium.org> Reviewed-by: Furquan Shaikh <furquan@google.com>
This commit is contained in:
@@ -438,6 +438,10 @@ int heci_receive(void *buff, size_t *maxlen)
|
||||
*/
|
||||
do {
|
||||
received = recv_one_message(&hdr, p, left);
|
||||
if (!received) {
|
||||
printk(BIOS_ERR, "HECI: Failed to recieve!\n");
|
||||
return 0;
|
||||
}
|
||||
left -= received;
|
||||
p += received;
|
||||
/* If we read out everything ping to send more */
|
||||
|
||||
Reference in New Issue
Block a user