sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ec/lenovo/h8: Add Kconfig option for Fn-Ctrl swap

Browse Source 
Having to use a runtime configurable option backend like CMOS just to
specify the value of the "fn_ctrl_swap" option is annoying. Introduce
a new Kconfig option to allow specifying the fallback value, which is
only used when the option backend cannot provide a value.

Change-Id: I00bb3cd60c443fc0c8adb82e8e0c436dfc5de24b
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/67836
Reviewed-by: Paul Menzel <paulepanter@mailbox.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
This commit is contained in:
Angel Pons
2022-09-26 16:26:30 +02:00
committed by Felix Held
parent acc91c335b
commit c6df44b959
2 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/ec/lenovo/h8/Kconfig
View File

@@ -28,6 +28,14 @@ config H8_SUPPORT_BT_ON_WIFI
Disable BDC detection and assume bluetooth is installed. Required for Disable BDC detection and assume bluetooth is installed. Required for
bluetooth on wifi cards, as it's not possible to detect it in coreboot. bluetooth on wifi cards, as it's not possible to detect it in coreboot.
config H8_FN_CTRL_SWAP
bool "Swap Fn and Ctrl keys"
help
Specifies the fallback value of the "fn_ctrl_swap" option, which is
only used when the value cannot be obtained from the option backend.
The main use-case for this Kconfig option is to enable Fn-Ctrl swap
without using any runtime configurable option backends (e.g. CMOS).
config H8_HAS_BAT_THRESHOLDS_IMPL config H8_HAS_BAT_THRESHOLDS_IMPL
bool bool
default n default n

2
src/ec/lenovo/h8/h8.c
View File

@@ -311,7 +311,7 @@ static void h8_enable(struct device *dev)
if (conf->has_uwb) if (conf->has_uwb)
h8_uwb_enable(get_uint_option("uwb", 1)); h8_uwb_enable(get_uint_option("uwb", 1));
h8_fn_ctrl_swap(get_uint_option("fn_ctrl_swap", 0)); h8_fn_ctrl_swap(get_uint_option("fn_ctrl_swap", CONFIG(H8_FN_CTRL_SWAP)));
h8_sticky_fn(get_uint_option("sticky_fn", 0)); h8_sticky_fn(get_uint_option("sticky_fn", 0));