slippy/falco/peppy: Fix SPD GPIO initialization.
SPD GPIOs were being read prior to initialization in romstage_common. To fix, pass the copy_spd function to romstage_common, to be called at the appropriate time (after PCH init, before DRAM init). Change-Id: I2554813e56a58c8c81456f1a53cc8ce9c2030a73 Signed-off-by: Aaron Durbin <adurbin@chromium.org> Signed-off-by: Shawn Nematbakhsh <shawnn@chromium.org> Reviewed-on: https://gerrit.chromium.org/gerrit/58608 Reviewed-on: http://review.coreboot.org/4237 Tested-by: build bot (Jenkins) Reviewed-by: Ronald G. Minnich <rminnich@gmail.com>
This commit is contained in:
committed by
Alexandru Gagniuc
parent
752b1e6d5d
commit
c7633f4f5e
@@ -151,6 +151,7 @@ struct romstage_params {
|
||||
const void *gpio_map;
|
||||
const struct rcba_config_instruction *rcba_config;
|
||||
unsigned long bist;
|
||||
void (*copy_spd)(struct pei_data *);
|
||||
};
|
||||
void mainboard_romstage_entry(unsigned long bist);
|
||||
void romstage_common(const struct romstage_params *params);
|
||||
|
@@ -246,6 +246,9 @@ void romstage_common(const struct romstage_params *params)
|
||||
|
||||
report_platform_info();
|
||||
|
||||
if (params->copy_spd != NULL)
|
||||
params->copy_spd(params->pei_data);
|
||||
|
||||
sdram_initialize(params->pei_data);
|
||||
|
||||
timestamp_add_now(TS_AFTER_INITRAM);
|
||||
|
Reference in New Issue
Block a user