From c7759d1cf9e3d42d4a75183eb7272bb24202a604 Mon Sep 17 00:00:00 2001 From: Felix Singer Date: Mon, 8 May 2023 19:28:10 +0200 Subject: [PATCH] mb/google/cherry: Move selects from Kconfig.name to Kconfig Selects should be done in the Kconfig file instead of Kconfig.name and not mixed over both files. Change-Id: Id1b0d375670f9e59047eff737bc17e61bf93175e Signed-off-by: Felix Singer Reviewed-on: https://review.coreboot.org/c/coreboot/+/75016 Reviewed-by: Martin L Roth Tested-by: build bot (Jenkins) --- src/mainboard/google/cherry/Kconfig | 9 +++++++++ src/mainboard/google/cherry/Kconfig.name | 3 --- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/mainboard/google/cherry/Kconfig b/src/mainboard/google/cherry/Kconfig index 2816f9ba89..3da6725076 100644 --- a/src/mainboard/google/cherry/Kconfig +++ b/src/mainboard/google/cherry/Kconfig @@ -4,6 +4,15 @@ config BOARD_GOOGLE_CHERRY_COMMON def_bool n +config BOARD_GOOGLE_CHERRY + select BOARD_GOOGLE_CHERRY_COMMON + +config BOARD_GOOGLE_DOJO + select BOARD_GOOGLE_CHERRY_COMMON + +config BOARD_GOOGLE_TOMATO + select BOARD_GOOGLE_CHERRY_COMMON + if BOARD_GOOGLE_CHERRY_COMMON config VBOOT diff --git a/src/mainboard/google/cherry/Kconfig.name b/src/mainboard/google/cherry/Kconfig.name index 9c58e518e6..72194f9ff5 100644 --- a/src/mainboard/google/cherry/Kconfig.name +++ b/src/mainboard/google/cherry/Kconfig.name @@ -2,12 +2,9 @@ comment "Cherry" config BOARD_GOOGLE_CHERRY bool "-> Cherry" - select BOARD_GOOGLE_CHERRY_COMMON config BOARD_GOOGLE_DOJO bool "-> Dojo" - select BOARD_GOOGLE_CHERRY_COMMON config BOARD_GOOGLE_TOMATO bool "-> Tomato" - select BOARD_GOOGLE_CHERRY_COMMON