sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ec/google/chromeec: Update google_chromeec_get_board_version prototype

Browse Source 
The helper function to get the board version from EC returns 0 on
failure. But 0 is also a valid board version. Update the helper function
to return -1 on failure and update the use-cases.

BUG=b:114001972,b:114677884,b:114677887

Change-Id: I93e8dbce2ff26e76504b132055985f53cbf07d31
Signed-off-by: Karthikeyan Ramasubramanian <kramasub@google.com>
Tested-by: Karthikeyan Ramasubramanian <kramasub@google.com>
Reviewed-on: https://review.coreboot.org/28576
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Jett Rink <jettrink@google.com>
This commit is contained in:
Karthikeyan Ramasubramanian
2018-09-17 16:19:34 -06:00
committed by Martin Roth
parent 2beadeec35
commit c80ff8437d
13 changed files with 72 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/include/boardid.h
View File

@ -20,6 +20,15 @@
#define UNDEFINED_STRAPPING_ID (~0)
#define BOARD_ID_UNKNOWN ~((uint32_t)0) /* unsigned equivalent to -1 */
#define BOARD_ID_INIT ~((uint32_t)1) /* unsigned equivalent to -2 */
/**
* board_id() - Get the board version
*
* Return: board version on success, BOARD_ID_UNKNOWN on failure/error.
*
* This function is used to get the mainboard version.
*/
uint32_t board_id(void); /* differentiates revisions */
uint32_t ram_code(void); /* identifies installed DRAM modules */
uint32_t sku_id(void); /* differentiates other optional components */