sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/alderlake: remove unnecessary test condition

Browse Source 
mch_id is set to zero and then unnecessarily tested.

TEST=build and boot image on ADL RVP board

Signed-off-by: Jeremy Compostella <jeremy.compostella@intel.com>
Change-Id: I4f48742b04edd50fbc0db342b563534e709d6fdd
Reviewed-on: https://review.coreboot.org/c/coreboot/+/65583
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
This commit is contained in:
Jeremy Compostella
2022-06-30 16:31:14 -07:00
committed by Felix Held
parent 97074645b3
commit cb08c7937d
1 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/soc/intel/alderlake/fsp_params.c
View File

@@ -493,13 +493,9 @@ static unsigned int get_aspm_control(enum ASPM_control ctl)
/* This function returns the VccIn Aux Imon IccMax values for ADL-P and ADL-S SKU's */ /* This function returns the VccIn Aux Imon IccMax values for ADL-P and ADL-S SKU's */
static uint16_t get_vccin_aux_imon_iccmax(void) static uint16_t get_vccin_aux_imon_iccmax(void)
{ {
uint16_t mch_id = 0;
uint8_t tdp;
if (!mch_id) {
struct device *dev = pcidev_path_on_root(SA_DEVFN_ROOT); struct device *dev = pcidev_path_on_root(SA_DEVFN_ROOT);
mch_id = dev ? pci_read_config16(dev, PCI_DEVICE_ID) : 0xffff; uint16_t mch_id = dev ? pci_read_config16(dev, PCI_DEVICE_ID) : 0xffff;
} uint8_t tdp;
switch (mch_id) { switch (mch_id) {
case PCI_DID_INTEL_ADL_P_ID_1: case PCI_DID_INTEL_ADL_P_ID_1: