sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

CBMEM: Always select CAR_MIGRATION

Browse Source 
If romstage does not make cbmem_initialize() call, linker should
optimize the code for CAR migration away.

This simplifies design of CBMEM console by a considerable amount.
As console buffer is now migrated within cbmem_initialize() call there
is no longer need for cbmemc_reinit() call made at end of romstage.

Change-Id: I8675ecaafb641fa02675e9ba3f374caa8e240f1d
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: http://review.coreboot.org/3916
Tested-by: build bot (Jenkins)
Reviewed-by: Aaron Durbin <adurbin@google.com>
This commit is contained in:
Kyösti Mälkki
2013-09-10 00:07:21 +03:00
parent de1fe7f655
commit cbf5bdfe67
24 changed files with 14 additions and 121 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/mainboard/emulation/qemu-i440fx/romstage.c
View File

@@ -51,11 +51,6 @@ void main(unsigned long bist)
cbmem_was_initted = !cbmem_initialize();
timestamp_init(rdtsc());
timestamp_sync();
timestamp_add_now(TS_START_ROMSTAGE);
#if CONFIG_CONSOLE_CBMEM
/* Keep this the last thing this function does. */
cbmemc_reinit();
#endif
}

5
src/mainboard/emulation/qemu-q35/romstage.c
View File

@@ -53,11 +53,6 @@ void main(unsigned long bist)
cbmem_was_initted = !cbmem_initialize();
timestamp_init(rdtsc());
timestamp_sync();
timestamp_add_now(TS_START_ROMSTAGE);
#if CONFIG_CONSOLE_CBMEM
/* Keep this the last thing this function does. */
cbmemc_reinit();
#endif
}