Define global uma_memory variables

Use of the uma_memory_base and _size variables is very scattered.
Implementation of setup_uma_memory() will appear in each northbridge.

It should be possible to do this setup entirely in northbridge
code and get rid of the globals in a follow-up.

Change-Id: I07ccd98c55a6bcaa8294ad9704b88d7afb341456
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: http://review.coreboot.org/1204
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <patrick@georgi-clan.de>
This commit is contained in:
Kyösti Mälkki
2012-07-11 07:55:21 +03:00
committed by Patrick Georgi
parent 63f8c08830
commit cc55b9b919
50 changed files with 10 additions and 105 deletions

View File

@@ -908,10 +908,6 @@ static struct hw_mem_hole_info get_hw_mem_hole_info(void)
}
#endif
#if CONFIG_GFXUMA
extern uint64_t uma_memory_base, uma_memory_size;
#endif
static void amdfam10_domain_set_resources(device_t dev)
{
#if CONFIG_PCI_64BIT_PREF_MEM

View File

@@ -338,10 +338,6 @@ static struct hw_mem_hole_info get_hw_mem_hole_info(void)
}
#endif
#if CONFIG_GFXUMA
extern uint64_t uma_memory_base, uma_memory_size;
#endif
static void read_resources(device_t dev)
{
u32 nodeid;

View File

@@ -326,10 +326,6 @@ static struct hw_mem_hole_info get_hw_mem_hole_info(void)
}
#endif
#if CONFIG_GFXUMA
extern uint64_t uma_memory_base, uma_memory_size;
#endif
static void read_resources(device_t dev)
{
u32 nodeid;

View File

@@ -626,10 +626,6 @@ static struct hw_mem_hole_info get_hw_mem_hole_info(void)
}
#endif
#if CONFIG_GFXUMA
extern uint64_t uma_memory_base, uma_memory_size;
#endif
static void domain_set_resources(device_t dev)
{
#if CONFIG_PCI_64BIT_PREF_MEM

View File

@@ -613,10 +613,6 @@ static struct hw_mem_hole_info get_hw_mem_hole_info(void)
}
#endif
#if CONFIG_GFXUMA == 1
extern uint64_t uma_memory_base, uma_memory_size;
#endif
static void domain_set_resources(device_t dev)
{
#if CONFIG_PCI_64BIT_PREF_MEM == 1

View File

@@ -847,10 +847,6 @@ static void disable_hoist_memory(unsigned long hole_startk, int node_id)
#include <cbmem.h>
#endif
#if CONFIG_GFXUMA
extern uint64_t uma_memory_base, uma_memory_size;
#endif
static void amdfam10_domain_set_resources(device_t dev)
{
#if CONFIG_PCI_64BIT_PREF_MEM

View File

@@ -822,10 +822,6 @@ static u32 hoist_memory(unsigned long hole_startk, int node_id)
#include <cbmem.h>
#endif
#if CONFIG_GFXUMA
extern uint64_t uma_memory_base, uma_memory_size;
#endif
static void amdk8_domain_set_resources(device_t dev)
{
#if CONFIG_PCI_64BIT_PREF_MEM

View File

@@ -62,9 +62,6 @@ static const struct pci_driver i810e_northbridge_driver __pci_driver = {
.device = 0x7124,
};
/* IGD UMA memory */
uint64_t uma_memory_base=0, uma_memory_size=0;
int add_northbridge_resources(struct lb_memory *mem)
{
printk(BIOS_DEBUG, "Adding IGD UMA memory area\n");

View File

@@ -52,9 +52,6 @@ static const struct pci_driver northbridge_driver __pci_driver = {
.device = 0x3575,
};
/* IGD memory */
uint64_t uma_memory_base=0, uma_memory_size=0;
int add_northbridge_resources(struct lb_memory *mem)
{
printk(BIOS_DEBUG, "Adding IGD UMA memory area\n");

View File

@@ -68,9 +68,6 @@ static int get_pcie_bar(u32 *base, u32 *len)
return 0;
}
/* IDG memory */
uint64_t uma_memory_base=0, uma_memory_size=0;
static void add_fixed_resources(struct device *dev, int index)
{
struct resource *resource;

View File

@@ -118,9 +118,6 @@ static int get_pcie_bar(u32 *base, u32 *len)
return 0;
}
/* IDG memory */
uint64_t uma_memory_base=0, uma_memory_size=0;
static void add_fixed_resources(struct device *dev, int index)
{
struct resource *resource;

View File

@@ -73,9 +73,6 @@ static int get_pcie_bar(u32 *base, u32 *len)
return 0;
}
/* IDG memory */
u64 uma_memory_base = 0, uma_memory_size = 0;
static void add_fixed_resources(struct device *dev, int index)
{
struct resource *resource;