sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/clevo/kbl-u: drop duplicated configuration of UART pads

Browse Source 
UART pads already get configured in bootblock by the UART driver in soc
code. Thus, drop the duplicated code from the mainboard.

Change-Id: I95565a74e19d693a7d5ead81e72592cc4ca2038c
Signed-off-by: Michael Niewöhner <foss@mniewoehner.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/48594
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by:  Felix Singer <felixsinger@posteo.net>
This commit is contained in:
Michael Niewöhner 2020-12-12 01:51:41 +01:00
parent 1a0071c711
commit ccceb2250e
4 changed files with 0 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/mainboard/clevo/kbl-u/Makefile.inc
View File

@ -2,9 +2,6 @@
CPPFLAGS_common += -I$(src)/mainboard/$(MAINBOARDDIR)/include CPPFLAGS_common += -I$(src)/mainboard/$(MAINBOARDDIR)/include
bootblock-y += bootblock.c
bootblock-y += variants/$(VARIANT_DIR)/gpio_early.c
ramstage-y += ramstage.c ramstage-y += ramstage.c
ramstage-y += variants/$(VARIANT_DIR)/hda_verb.c ramstage-y += variants/$(VARIANT_DIR)/hda_verb.c
ramstage-y += variants/$(VARIANT_DIR)/gpio.c ramstage-y += variants/$(VARIANT_DIR)/gpio.c

9
src/mainboard/clevo/kbl-u/bootblock.c
View File

@ -1,9 +0,0 @@
/* SPDX-License-Identifier: GPL-2.0-only */
#include <bootblock_common.h>
#include <variant/gpio.h>
void bootblock_mainboard_early_init(void)
{
variant_configure_early_gpios();
}

1
src/mainboard/clevo/kbl-u/include/variant/gpio.h
View File

@ -3,7 +3,6 @@
#ifndef VARIANT_GPIO_H #ifndef VARIANT_GPIO_H
#define VARIANT_GPIO_H #define VARIANT_GPIO_H
void variant_configure_early_gpios(void);
void variant_configure_gpios(void); void variant_configure_gpios(void);
#endif #endif

17
src/mainboard/clevo/kbl-u/variants/n13xwu/gpio_early.c
View File

@ -1,17 +0,0 @@
/* SPDX-License-Identifier: GPL-2.0-only */
#include <soc/gpio.h>
#include <variant/gpio.h>
static const struct pad_config early_gpio_table[] = {
// UART2_RXD
_PAD_CFG_STRUCT(GPP_C20, 0x44000702, 0x0),
// UART2_TXD
_PAD_CFG_STRUCT(GPP_C21, 0x44000700, 0x0)
};
void variant_configure_early_gpios(void)
{
gpio_configure_pads(early_gpio_table, ARRAY_SIZE(early_gpio_table));
}