sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

src/superio/smsc/lpc47m15x: Avoid #include early_serial.c

Browse Source 
Provide proper header and function type-signatures for Super I/O
romstage component.

Fix mainboard's bogous romstage component to match.

Change-Id: Icd02199690d0c428b2daadf702d50714dc367692
Signed-off-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
Reviewed-on: http://review.coreboot.org/5924
Tested-by: build bot (Jenkins)
Reviewed-by: Marc Jones <marc.jones@se-eng.com>
This commit is contained in:
Edward O'Callaghan
2014-06-03 08:40:34 +10:00
parent 031cf214c6
commit cf5ac3d7ef
4 changed files with 19 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/superio/smsc/lpc47m15x/Makefile.inc
View File

@@ -17,4 +17,5 @@
## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
##
romstage-$(CONFIG_SUPERIO_SMSC_LPC47M15X) += early_serial.c
ramstage-$(CONFIG_SUPERIO_SMSC_LPC47M15X) += superio.c

5
src/superio/smsc/lpc47m15x/early_serial.c
View File

@@ -20,6 +20,9 @@
/* Pre-RAM driver for the SMSC LPC47M15X Super I/O chip */
#include <arch/io.h>
#include <device/pnp.h>
#include <stdint.h>
#include "lpc47m15x.h"
static void pnp_enter_conf_state(device_t dev)
@@ -34,7 +37,7 @@ static void pnp_exit_conf_state(device_t dev)
outb(0xaa, port);
}
static inline void lpc47m15x_enable_serial(device_t dev, u16 iobase)
void lpc47m15x_enable_serial(device_t dev, u16 iobase)
{
pnp_enter_conf_state(dev);
pnp_set_logical_device(dev);

11
src/superio/smsc/lpc47m15x/lpc47m15x.h
View File

@@ -17,8 +17,8 @@
* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
*/
#ifndef SUPERIO_SMSC_LPC47M15X_LPC47M15X_H
#define SUPERIO_SMSC_LPC47M15X_LPC47M15X_H
#ifndef SUPERIO_SMSC_LPC47M15X_H
#define SUPERIO_SMSC_LPC47M15X_H
#define LPC47M15X_FDC 0 /* Floppy */
#define LPC47M15X_PP 3 /* Parallel Port */
@@ -31,4 +31,9 @@
#define LPC47M15X2_MAX_CONFIG_REGISTER 0x5F
#endif
#include <arch/io.h>
#include <stdint.h>
void lpc47m15x_enable_serial(device_t dev, u16 iobase);
#endif /* SUPERIO_SMSC_LPC47M15X_H */