sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/apollolake: Fix CONFIG_FSP_CAR build error

Browse Source 
Remove cpu.h from the cache-as-ram setup and teardown files that rely
on the FSP implementation.  The struct device statement causes a
build failure and there appears to be nothing needed from cpu.h in
the two .S files.

TEST: Build Google Reef with FSP_CAR selected on Chipset menu and add
      FSP binaries on the Generic Drivers menu.

Change-Id: I560b730c18d7ec73b65f2e195b790e7dcacfd6bb
Signed-off-by: Marshall Dawson <marshalldawson3rd@gmail.com>
Reviewed-on: https://review.coreboot.org/21057
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
This commit is contained in:
Marshall Dawson 2017-08-16 15:49:50 -06:00 committed by Aaron Durbin
parent e6aab7f120
commit d0269a636d
2 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/soc/intel/apollolake/bootblock/cache_as_ram_fsp.S
View File

@ -19,7 +19,6 @@
#include <cpu/x86/cache.h> #include <cpu/x86/cache.h>
#include <cpu/x86/cr.h> #include <cpu/x86/cr.h>
#include <cpu/x86/post_code.h> #include <cpu/x86/post_code.h>
#include <soc/cpu.h>
#include <../../../arch/x86/walkcbfs.S> #include <../../../arch/x86/walkcbfs.S>

1
src/soc/intel/apollolake/exit_car_fsp.S
View File

@ -16,7 +16,6 @@
#include <cpu/x86/mtrr.h> #include <cpu/x86/mtrr.h>
#include <cpu/x86/cr.h> #include <cpu/x86/cr.h>
#include <soc/cpu.h>
/* /*
* This path for CAR teardown is taken when CONFIG_FSP_CAR is employed. * This path for CAR teardown is taken when CONFIG_FSP_CAR is employed.