acpi: Call acpi_fill_ssdt() only for enabled devices
Individual drivers check whether the concerned device is enabled before filling in the SSDT. Move the check before calling acpi_fill_ssdt() and remove the check in the individual drivers. BUG=None TEST=util/abuild/abuild Change-Id: Ib042bec7e8c68b38fafa60a8e965d781bddcd1f0 Signed-off-by: Karthikeyan Ramasubramanian <kramasub@google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/47148 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Furquan Shaikh <furquan@google.com> Reviewed-by: Sumeet R Pawnikar <sumeet.r.pawnikar@intel.com> Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org> Reviewed-by: Angel Pons <th3fanbus@gmail.com> Reviewed-by: Christian Walter <christian.walter@9elements.com>
This commit is contained in:
committed by
Patrick Georgi
parent
04582e9001
commit
d1c0f958d1
@@ -17,7 +17,7 @@ static void adau7002_fill_ssdt(const struct device *dev)
|
||||
struct drivers_generic_adau7002_config *config;
|
||||
struct acpi_dp *dp;
|
||||
|
||||
if (!dev || !dev->enabled)
|
||||
if (!dev)
|
||||
return;
|
||||
|
||||
const char *scope = acpi_device_scope(dev);
|
||||
|
@@ -57,7 +57,7 @@ static void gpio_keys_fill_ssdt_generator(const struct device *dev)
|
||||
const char *drv_string = config->is_polled ? "gpio-keys-polled"
|
||||
: "gpio-keys";
|
||||
|
||||
if (!dev->enabled || !scope || !path || !config->gpio.pin_count)
|
||||
if (!scope || !path || !config->gpio.pin_count)
|
||||
return;
|
||||
|
||||
/* Device */
|
||||
|
@@ -18,7 +18,7 @@ static void max98357a_fill_ssdt(const struct device *dev)
|
||||
const char *path;
|
||||
struct acpi_dp *dp;
|
||||
|
||||
if (!dev->enabled || !config)
|
||||
if (!config)
|
||||
return;
|
||||
|
||||
const char *scope = acpi_device_scope(dev);
|
||||
|
Reference in New Issue
Block a user