sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

acpi: Call acpi_fill_ssdt() only for enabled devices

Browse Source 
Individual drivers check whether the concerned device is enabled before
filling in the SSDT. Move the check before calling acpi_fill_ssdt() and
remove the check in the individual drivers.

BUG=None
TEST=util/abuild/abuild

Change-Id: Ib042bec7e8c68b38fafa60a8e965d781bddcd1f0
Signed-off-by: Karthikeyan Ramasubramanian <kramasub@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/47148
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
Reviewed-by: Sumeet R Pawnikar <sumeet.r.pawnikar@intel.com>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Christian Walter <christian.walter@9elements.com>
This commit is contained in:
Karthikeyan Ramasubramanian
2020-11-02 16:26:52 -07:00
committed by Patrick Georgi
parent 04582e9001
commit d1c0f958d1
37 changed files with 29 additions and 56 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/ec/google/chromeec/audio_codec/audio_codec.c
View File

@@ -15,7 +15,7 @@ static void crosec_audio_codec_fill_ssdt(const struct device *dev)
const char *scope = acpi_device_scope(dev);
struct ec_google_chromeec_audio_codec_config *cfg = dev->chip_info;
if (!dev->enabled || !scope || !cfg)
if (!scope || !cfg)
return;
acpigen_write_scope(scope);

3
src/ec/google/chromeec/ec_acpi.c
View File

@@ -223,9 +223,6 @@ void google_chromeec_fill_ssdt_generator(const struct device *dev)
struct device_path path;
struct device *ec;
if (!dev->enabled)
return;
/* Set up a minimal EC0 device to pass to the DPTF helpers */
path.type = DEVICE_PATH_GENERIC;
path.generic.id = 0;

2
src/ec/google/chromeec/i2c_tunnel/i2c_tunnel.c
View File

@@ -17,7 +17,7 @@ static void crosec_i2c_tunnel_fill_ssdt(const struct device *dev)
struct ec_google_chromeec_i2c_tunnel_config *cfg = dev->chip_info;
struct acpi_dp *dsd;
if (!dev->enabled || !scope || !cfg)
if (!scope || !cfg)
return;
acpigen_write_scope(scope);

3
src/ec/google/wilco/chip.c
View File

@@ -184,9 +184,6 @@ static void wilco_ec_fill_ssdt_generator(const struct device *dev)
void *region_ptr;
size_t ucsi_alloc_region_len;
if (!dev->enabled)
return;
ucsi_alloc_region_len = ucsi_region_len < UCSI_MIN_ALLOC_REGION_LEN ?
UCSI_MIN_ALLOC_REGION_LEN : ucsi_region_len;
region_ptr = cbmem_add(CBMEM_ID_ACPI_UCSI, ucsi_alloc_region_len);