sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

drivers/elog: Fix ELOG_GSMI dependency

Browse Source 
SMM_TSEG is a qualifier between TSEG and ASEG only, while
HAVE_SMI_HANDLER currently tells if SMM will be installed.

Move rest of the file under same 'if ELOG' block.

Change-Id: I620d3ce5aa9632d862d6480922144f002cf6423b
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/34195
Reviewed-by: Furquan Shaikh <furquan@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Kyösti Mälkki 2019-07-12 01:29:46 +03:00
parent d4e140dae7
commit d1c1c9a76e
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/drivers/elog/Kconfig
View File

@ -42,10 +42,8 @@ config ELOG_PRERAM
help help
This option will enable event logging from the preram stage. This option will enable event logging from the preram stage.
endif
config ELOG_GSMI config ELOG_GSMI
depends on ELOG && SMM_TSEG depends on HAVE_SMI_HANDLER
bool "SMI interface to write and clear event log" bool "SMI interface to write and clear event log"
select SPI_FLASH_SMM if BOOT_DEVICE_SPI_FLASH_RW_NOMMAP select SPI_FLASH_SMM if BOOT_DEVICE_SPI_FLASH_RW_NOMMAP
default n default n
@ -55,7 +53,6 @@ config ELOG_GSMI
kernel reset/shutdown messages to the event log. kernel reset/shutdown messages to the event log.
config ELOG_BOOT_COUNT config ELOG_BOOT_COUNT
depends on ELOG
bool "Maintain a monotonic boot number in CMOS" bool "Maintain a monotonic boot number in CMOS"
default n default n
help help
@ -64,9 +61,11 @@ config ELOG_BOOT_COUNT
counter will be logged as part of the System Boot event. counter will be logged as part of the System Boot event.
config ELOG_BOOT_COUNT_CMOS_OFFSET config ELOG_BOOT_COUNT_CMOS_OFFSET
depends on ELOG && ELOG_BOOT_COUNT && !USE_OPTION_TABLE depends on ELOG_BOOT_COUNT && !USE_OPTION_TABLE
int "Offset in CMOS to store the boot count" int "Offset in CMOS to store the boot count"
default 0 default 0
help help
This value must be greater than 16 bytes so as not to interfere This value must be greater than 16 bytes so as not to interfere
with the standard RTC region. Requires 8 bytes. with the standard RTC region. Requires 8 bytes.
endif