cpu/x86/mp_init: use cb_err as mp_init_with_smm return type
Using cb_err as return type clarifies the meaning of the different return values. This patch also adds the types.h include that provides the definition of the cb_err enum and checks the return value of mp_init_with_smm against the enum values instead of either checking if it's non-zero or less than zero to handle the error case. Signed-off-by: Felix Held <felix-coreboot@felixheld.de> Change-Id: Ibcd4a9a63cc87fe176ba885ced0f00832587d492 Reviewed-on: https://review.coreboot.org/c/coreboot/+/58491 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
This commit is contained in:
@@ -17,6 +17,7 @@
|
||||
#include <soc/msr.h>
|
||||
#include <soc/pattrs.h>
|
||||
#include <soc/ramstage.h>
|
||||
#include <types.h>
|
||||
|
||||
/* Core level MSRs */
|
||||
static const struct reg_script core_msr_script[] = {
|
||||
@@ -196,6 +197,6 @@ void baytrail_init_cpus(struct device *dev)
|
||||
{
|
||||
struct bus *cpu_bus = dev->link_list;
|
||||
|
||||
if (mp_init_with_smm(cpu_bus, &mp_ops))
|
||||
if (mp_init_with_smm(cpu_bus, &mp_ops) != CB_SUCCESS)
|
||||
printk(BIOS_ERR, "MP initialization failure.\n");
|
||||
}
|
||||
|
Reference in New Issue
Block a user