sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cpu/x86: Make SMM stack size configurable

Browse Source 
Stoneyridge is running into a stack overflow in the SMM handler.

BUG=b:80539294
TEST=built on grunt

Change-Id: I94e385497bd93c3638c69fb08d9b843c3bbb55ce
Signed-off-by: Raul E Rangel <rrangel@chromium.org>
Reviewed-on: https://review.coreboot.org/27034
Reviewed-by: Martin Roth <martinroth@google.com>
Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Raul E Rangel 2018-06-12 10:43:09 -06:00 committed by Patrick Georgi
parent f0afb3e335
commit d3b8393310
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/cpu/x86/Kconfig
View File

@ -110,6 +110,14 @@ config SMM_MODULE_HEAP_SIZE
This option determines the size of the heap within the SMM handler This option determines the size of the heap within the SMM handler
modules. modules.
config SMM_MODULE_STACK_SIZE
hex
default 0x400
depends on SMM_TSEG
help
This option determines the size of the stack within the SMM handler
modules.
config SMM_LAPIC_REMAP_MITIGATION config SMM_LAPIC_REMAP_MITIGATION
bool bool
default y if NORTHBRIDGE_INTEL_I945 default y if NORTHBRIDGE_INTEL_I945

2
src/cpu/x86/mp_init.c
View File

@ -795,7 +795,7 @@ static int install_permanent_handler(int num_cpus, uintptr_t smbase,
/* There are num_cpus concurrent stacks and num_cpus concurrent save /* There are num_cpus concurrent stacks and num_cpus concurrent save
* state areas. Lastly, set the stack size to 1KiB. */ * state areas. Lastly, set the stack size to 1KiB. */
struct smm_loader_params smm_params = { struct smm_loader_params smm_params = {
.per_cpu_stack_size = 1 * KiB, .per_cpu_stack_size = CONFIG_SMM_MODULE_STACK_SIZE,
.num_concurrent_stacks = num_cpus, .num_concurrent_stacks = num_cpus,
.per_cpu_save_state_size = save_state_size, .per_cpu_save_state_size = save_state_size,
.num_concurrent_save_states = num_cpus, .num_concurrent_save_states = num_cpus,